Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fcntl(G_GETFL) fails on VxWorks 6.9 #1153

Closed
skliper opened this issue Sep 16, 2021 · 0 comments · Fixed by #1157 or #1158
Closed

fcntl(G_GETFL) fails on VxWorks 6.9 #1153

skliper opened this issue Sep 16, 2021 · 0 comments · Fixed by #1157 or #1158
Assignees
@jphickey
Labels
bug vxworks
Milestone
Caelum

Comments

@skliper
Copy link
Contributor

skliper commented Sep 16, 2021

Is your feature request related to a problem? Please describe.
Now that we check the return for fcntl, turns out it fails on VxWorks 6.9 (not implemented). Used in OS_SocketOpen_Impl and OS_SocketAccept_Impl:

osal/src/os/portable/os-impl-bsd-sockets.c

Line 163 in 2a2defb

os_flags = fcntl(impl->fd, F_GETFL);

osal/src/os/portable/os-impl-bsd-sockets.c

Line 444 in 2a2defb

os_flags = fcntl(conn_impl->fd, F_GETFL);

Describe the solution you'd like
Consider trying ioctl if fcntl fails? Rumor has it ioctl is supported.

Describe alternatives you've considered
None

Additional context
None

Requester Info
Jacob Hageman - NASA/GSFC
@skliper skliper added this to the 6.0.0 milestone Sep 16, 2021
jphickey added a commit to jphickey/osal that referenced this issue Sep 21, 2021
@jphickey
Fix nasa#1153, add os-specifc socket flag function
84746cc 
Adds the capability for the bsd sockets implementation to use
a function provided by the OS layer to set the socket flags.

This allows VxWorks to have an alternative implementation that
uses ioctl rather than fcntl to set the flags.
@jphickey jphickey mentioned this issue Sep 21, 2021
Merged
jphickey added a commit to jphickey/osal that referenced this issue Sep 21, 2021
@jphickey
Fix nasa#1153, add os-specifc socket flag function
009abc1 
Adds the capability for the bsd sockets implementation to use
a function provided by the OS layer to set the socket flags.

This allows VxWorks to have an alternative implementation that
uses ioctl rather than fcntl to set the flags.
astrogeco added a commit that referenced this issue Sep 21, 2021
@astrogeco
Merge pull request #1157 from jphickey/fix-1153-avoid-fcntl-vxworks
5108df3 
Fix #1153, add os-specifc socket flag function
@astrogeco astrogeco mentioned this issue Sep 21, 2021
Merged
@skliper skliper added the bug label Sep 28, 2021
jphickey pushed a commit to jphickey/osal that referenced this issue Aug 10, 2022
@skliper
Fix nasa#1153, Remove logic based on LogEnabled status
693cb5d
jphickey pushed a commit to jphickey/osal that referenced this issue Aug 10, 2022
@astrogeco
Merge pull request nasa#1178 from skliper/fix1153-logenabled_logic
aded3e4 
Fix nasa#1153, Remove logic based on LogEnabled status
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jphickey jphickey

Labels
bug vxworks
Projects
None yet
Milestone
Caelum
3 participants
@jphickey @skliper @astrogeco