Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Formatting Issues with ICBundle Workflow #1402

Closed
dzbaker opened this issue Aug 9, 2023 · 0 comments
Closed

Formatting Issues with ICBundle Workflow #1402

dzbaker opened this issue Aug 9, 2023 · 0 comments

Comments

@dzbaker
Copy link
Collaborator

dzbaker commented Aug 9, 2023

Describe the bug
Similar to nasa/cFE#2419. There are some small formatting issues that should be corrected in the changelog/version.h updates made by the ICBundle workflow:

  1. An additional "#" is placed in front of "#Changelog" in Changelog.md
  2. An additional "#" is placed in front of "#define OS_BUILD_NUMBER ..." in src/os/inc/osapi-version.h
  3. Additional occurrences of the string "Changelog" are replaced in the Changelog.md file

To Reproduce
Steps to reproduce the behavior:

  1. Push a code change to a user-owned feature branch
  2. Submit a pull request for that code change
  3. Go to the "Actions" tab in GitHub and run the "Integration Candidate Bundle Generation" workflow with the PR number as the input argument for the field labeled "The pull request numbers to include (Comma separated):"
  4. Wait for the workflow to complete
  5. Inspect the newly updated/generated "integration-candidate branch"
  6. Observe the changes made to the Changelog.md and src/os/inc/osapi-version.h files by the workflow

Expected behavior

  1. No additional "#" is placed in front of "#Changelog" in Changelog.md
  2. No additional "#" is placed in front of "#define OS_BUILD_NUMBER ..." in src/os/inc/osapi-version.h
  3. Additional occurrences of the string "Changelog" are not replaced in the Changelog.md file

System observed on:
GitHub

Reporter Info
Dylan Z. Baker/NASA GSFC

dzbaker added a commit to dzbaker/osal that referenced this issue Aug 9, 2023
Fix nasa#1402, Fixes errors in IC Bundle workflow file
dzbaker added a commit that referenced this issue Sep 1, 2023
Fix #1402, Fixes errors in IC Bundle workflow file
@dzbaker dzbaker closed this as completed in e005828 Sep 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants