Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove vxworks6 coverage code, rename vxworks-ng to vxworks #266

Closed
jphickey opened this issue Oct 18, 2019 · 0 comments · Fixed by #281
Closed

Remove vxworks6 coverage code, rename vxworks-ng to vxworks #266

jphickey opened this issue Oct 18, 2019 · 0 comments · Fixed by #281
Assignees
@jphickey
Labels
bug
Milestone
Bootes

Comments

@jphickey
Copy link
Contributor

Describe the bug
For the unit-test-coverage code, the directory names must match those of the actual implementation they are testing. The build scripts assume/require this name relationship.

Recently, the classic OSAL implementations were dropped and the "-ng" implementations replaced them in the main code tree, but the unit-test-coverage still has the old vxworks6 and new vxworks-ng directories.

The old vxworks6 should be removed and the vxworks-ng needs to be renamed to be vxworks.

To Reproduce
Build coverage code using e.g.:
cmake -DOSALCOVERAGE_TARGET_OSTYPE='shared;vxworks-ng' -DOSAL_INCLUDEDIR=$CONFIG_DIR $OSAL_DIR/src/unit-test-coverage

The subsequent make will fail because there is no longer an OSAL implementation named vxworks-ng, it is named vxworks now.

Expected behavior
The build should complete successfully

System observed on:
Ubuntu 18.04.2 64-bit

Reporter Info
Joseph Hickey, Vantage Systems, Inc.
@jphickey jphickey self-assigned this Oct 18, 2019
jphickey added a commit to jphickey/osal that referenced this issue Oct 18, 2019
@jphickey
Fix nasa#266: Rename "vxworks-ng" and "posix-ng" coverage tests
4eb6848 
Rename to "vxworks" and "posix", respectively, to match the
actual implementation names.  The build scripts rely on
the name being the same and will fail if different.
@jphickey jphickey mentioned this issue Oct 18, 2019
Merged
@skliper skliper added this to the 5.1.0 milestone Oct 22, 2019
@skliper skliper added the bug label Oct 30, 2019
skliper added a commit that referenced this issue Oct 31, 2019
@skliper
CCB 20191023: Merge #267 #268 #270
342422a 
Fixes #230 #266 #269
Code reviewed and approved at 20191023 CCB
@skliper skliper mentioned this issue Oct 31, 2019
Merged
@skliper skliper closed this as completed in 89fec29 Nov 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jphickey jphickey

Labels
bug
Projects
None yet
Milestone
Bootes
Development

Successfully merging a pull request may close this issue.

Integration Candidate 20191030 nasa/osal
2 participants
@jphickey @skliper