Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OS_ModuleLoad_Impl function header does not match definition #357

Closed
matzipan opened this issue Jan 22, 2020 · 0 comments · Fixed by #356 or #369
Closed

OS_ModuleLoad_Impl function header does not match definition #357

matzipan opened this issue Jan 22, 2020 · 0 comments · Fixed by #356 or #369
Labels
Milestone

Comments

@matzipan
Copy link
Contributor

Describe the bug
When OS_INCLUDE_MODULE_LOADER is not defined, the function header does not
match the definition:

[ 98%] Building C object examples/rtems-cfs-hello-world/osal/CMakeFiles/osal.dir/src/os/rtems/osloader.obj
/home/andrei/Workspace/cFS/osal/src/os/rtems/osloader.c:320:7: error: conflicting types for 'OS_ModuleLoad_Impl'
 int32 OS_ModuleLoad_Impl ( uint32 module_id, char *translated_path )
       ^~~~~~~~~~~~~~~~~~
In file included from /home/andrei/Workspace/cFS/osal/src/os/rtems/os-rtems.h:39:0,
                 from /home/andrei/Workspace/on-board-software/vendor/cFS/osal/src/os/rtems/osloader.c:26:
/home/andrei/Workspace/cFS/osal/src/os/shared/os-impl.h:1230:7: note: previous declaration of 'OS_ModuleLoad_Impl' was here
 int32 OS_ModuleLoad_Impl ( uint32 module_id, const char *translated_path );

This issue was introduced in PR #21 .

To Reproduce
Build with OS_INCLUDE_MODULE_LOADER not defined.

Expected behavior
Build succeeds.

@skliper skliper added the bug label Feb 6, 2020
@skliper skliper added this to the 5.1.0 milestone Feb 6, 2020
@skliper skliper linked a pull request Feb 6, 2020 that will close this issue
astrogeco added a commit that referenced this issue Mar 9, 2020
@astrogeco astrogeco mentioned this issue Mar 10, 2020
astrogeco pushed a commit that referenced this issue Mar 10, 2020
When OS_INCLUDE_MODULE_LOADER is disabled, the function header does not
match the definition.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants