Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document that OS_ObjCreate() Id of new obj is > 0 #485

Closed
CDKnightNASA opened this issue Jun 1, 2020 · 0 comments · Fixed by #486 or #511
Closed

Document that OS_ObjCreate() Id of new obj is > 0 #485

CDKnightNASA opened this issue Jun 1, 2020 · 0 comments · Fixed by #486 or #511
Assignees
@CDKnightNASA
Labels
docs
Milestone
Bootes

Comments

@CDKnightNASA
Copy link
Contributor

Is your feature request related to a problem? Please describe.
The OS_Create() functions always generate an ID as an "out" parameter and that ID is always > 0 when the creation succeeds. This is useful as users of these API's as they can assume 0 is not a valid ID (such as in arrays or variables that are not always referring to valid objects.)

Describe the solution you'd like
Should describe, in the comments for all OS_Create functions, that ID will always be > 0.

Requester Info
Christopher.D.Knight@nasa.gov
@CDKnightNASA CDKnightNASA self-assigned this Jun 1, 2020
CDKnightNASA added a commit to CDKnightNASA/osal that referenced this issue Jun 1, 2020
@CDKnightNASA
fix nasa#485 - add text to make clear that IDs are non-zero
d3b0c81
@CDKnightNASA CDKnightNASA mentioned this issue Jun 1, 2020
Merged
astrogeco added a commit that referenced this issue Jun 17, 2020
@astrogeco
Merge pull request #486 from CDKnightNASA/fix-485-objid_gt_zero
96fcad7 
Fix #485 - add text to make clear that IDs are non-zero
@astrogeco astrogeco mentioned this issue Jun 17, 2020
Merged
@astrogeco astrogeco added this to the v5.1.0 milestone Sep 28, 2020
@astrogeco astrogeco changed the title Document that OS_<obj>Create() -- id of new <obj> is > 0 Document that OS_ObjCreate() -- id of new obj is > 0 Sep 28, 2020
@astrogeco astrogeco changed the title Document that OS_ObjCreate() -- id of new obj is > 0 Document that OS_ObjCreate() Id of new obj is > 0 Sep 28, 2020
jphickey pushed a commit to jphickey/osal that referenced this issue Aug 10, 2022
@astrogeco
Merge pull request nasa#485 from dmknutsen/issue_274
dccf3b2 
Fix nasa#274, NumOfChildTasks not decremented
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@CDKnightNASA CDKnightNASA

Labels
docs
Projects
None yet
Milestone
Bootes
2 participants
@CDKnightNASA @astrogeco