Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1025, Add Coding Standard Rules in CodeQL #1034

Closed
wants to merge 17 commits into from
Closed

Fix #1025, Add Coding Standard Rules in CodeQL #1034

wants to merge 17 commits into from

Conversation

ArielSAdamsNASA
Copy link
Contributor

Describe the contribution
Fix #1025
Added the duplicate jobs action to avoid duplicate jobs from running. Added a separate job for coding standard queries. Created two configuration files, one for default queries and security queries and another for jpl rules.

Testing performed
Testing done on forked repository, ArielSAdamsNASA/cFE.

Jobs were failing when the entire path of the configuration file were not used. Have to use nasa/cFE/.github/codeql/config-name@branch-name. The branch must be included in the path.

The CodeQL analysis workflow will fail for this PR since it is calling for a configuration file in main the main branch. It will not work until the configuration files are merged into main.

To prove that this workflow will work, I tested a workflow on a forked repository. In the screenshot, the configuration path is changed to the forked repo and tested branch and successfully runs both CodeQL jobs.

image

Expected behavior changes
There should be one job for security queries and one job for JPL and MISRA queries.

Third party code
Skip duplicate workflows license: https://github.com/fkirc/skip-duplicate-actions/blob/master/LICENSE

CodeQL license: https://github.com/github/codeql-action/blob/main/LICENSE

Contributor Info - All information REQUIRED for consideration of pull request
Ariel Adams, ASRC Federal

@ArielSAdamsNASA ArielSAdamsNASA marked this pull request as draft May 20, 2021 18:32
@ArielSAdamsNASA ArielSAdamsNASA deleted the fix-1025-coding-standards-codeql branch May 20, 2021 18:39
@skliper
Copy link
Contributor

skliper commented May 20, 2021

@ArielSAdamsNASA Could you document the reason for closure and add the appropriate tag (invalid, wontfix, duplicate, etc)?

@ArielSAdamsNASA
Copy link
Contributor Author

Closed due to duplicate and newer PR.

@skliper
Copy link
Contributor

skliper commented May 21, 2021

Duplicate of #1042

@skliper skliper marked this as a duplicate of #1042 May 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement JPL Rules in CodeQL
3 participants