Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1150, Set OSAL Loader unit test number of modules to OSAL_CONFIG_MAX_MODULES. #1265

Merged

Conversation

dzbaker
Copy link
Collaborator

@dzbaker dzbaker commented Jun 29, 2022

Checklist (Please check before submitting)

Describe the contribution
Fixes #1150

Testing performed
Printed value of MOD variable in CMakeLists.txt to ensure that it gets set to one more than the OSAL_CONFIG_MAX_MODULES value

Ran OSAL unit tests

Expected behavior changes
OSAL Loader unit tests will now support up to OSAL_CONFIG_MAX_MODULES modules.

System(s) tested on

  • OS: RHEL 8.6

@dzbaker dzbaker requested a review from jphickey June 29, 2022 15:31
@dzbaker dzbaker changed the title Set OSAL Loader unit test number of modules to OSAL_CONFIG_MAX_MODULES. Fix #1150: Set OSAL Loader unit test number of modules to OSAL_CONFIG_MAX_MODULES. Jun 29, 2022
@dzbaker dzbaker changed the title Fix #1150: Set OSAL Loader unit test number of modules to OSAL_CONFIG_MAX_MODULES. Fix #1150, Set OSAL Loader unit test number of modules to OSAL_CONFIG_MAX_MODULES. Jun 29, 2022
Copy link
Contributor

@jphickey jphickey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@dzbaker dzbaker added the CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) label Jul 6, 2022
@dzbaker
Copy link
Collaborator Author

dzbaker commented Jul 6, 2022

CCB 7/6/2022: Amend commit message to follow prescribed format

@dzbaker dzbaker added CCB:Approved Indicates code review and approval by community CCB and removed CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) labels Jul 6, 2022
@dzbaker dzbaker force-pushed the fix-1150-osal-loader-ut-hardcoded-modules branch from a69dd76 to 02aa1d2 Compare July 6, 2022 18:18
@dzbaker dzbaker requested a review from skliper July 6, 2022 18:23
dzbaker added a commit to nasa/cFS that referenced this pull request Jul 7, 2022
*Combines:*

osal v6.0.0-rc4+dev93
ci_lab v2.5.0-rc4+dev22
to_lab v2.5.0-rc4+dev24
sch_lab v2.5.0-rc4+dev31

**Includes:**

- nasa/osal#1265, Set OSAL Loader unit test number of modules to OSAL_CONFIG_MAX_MODULES

*Update Minimum CMake Version*
- nasa/osal#1267, Update minimum required cmake version
- nasa/ci_lab#113, update cmake_minimum_required
- nasa/sch_lab#117, update cmake_minimum_required

Co-authored by: Jacob Hageman  <skliper@users.noreply.github.com>
Co-authored by: Ariel Adams    <arielsadamsnasa@users.noreply.github.com>
Co-authored by: Joseph Hickey  <jphickey@users.noreply.github.com>
@dzbaker dzbaker merged commit 010303b into nasa:main Jul 8, 2022
dzbaker added a commit to nasa/cFS that referenced this pull request Jul 8, 2022
*Combines:*

osal v6.0.0-rc4+dev93
ci_lab v2.5.0-rc4+dev22
to_lab v2.5.0-rc4+dev24
sch_lab v2.5.0-rc4+dev31

**Includes:**

- nasa/osal#1265, Set OSAL Loader unit test number of modules to OSAL_CONFIG_MAX_MODULES

*Update Minimum CMake Version*
- nasa/osal#1267, Update minimum required cmake version
- nasa/ci_lab#113, update cmake_minimum_required
- nasa/sch_lab#117, update cmake_minimum_required

Co-authored by: Jacob Hageman  <skliper@users.noreply.github.com>
Co-authored by: Ariel Adams    <arielsadamsnasa@users.noreply.github.com>
Co-authored by: Joseph Hickey  <jphickey@users.noreply.github.com>
@skliper skliper added this to the Draco milestone Jul 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CCB:Approved Indicates code review and approval by community CCB draco-rc3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OSAL loader unit test builds hardcoded 32 modules, test fails if more modules are supported
3 participants