Fix #1300, do not set file permissions on UT assert outputs #1301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jphickey
added
CCB:Ready
File permissions in general are a POSIX concept, but this tool should be pure C99. It should not rely on any POSIX headers or POSIX-specific API calls.
jphickey
force-pushed
the
fix-1300-posix-perms
branch
from
273cf16
to
42a1eed
Compare
dmknutsen
approved these changes
Oct 4, 2022
dzbaker
added a commit
to nasa/cFS
that referenced
this pull request
Oct 4, 2022
*Combines:* osal v6.0.0-rc4+dev120 **Includes:** - nasa/osal#1301, do not set file permissions on UT assert outputs Co-authored-by: Dan Knutsen <dmknutsen@users.noreply.github.com> Co-authored-by: Joseph Hickey <jphickey@users.noreply.github.com>
dzbaker
added a commit
to nasa/cFS
that referenced
this pull request
Oct 4, 2022
*Combines:* osal v6.0.0-rc4+dev120 **Includes:** - nasa/osal#1301, do not set file permissions on UT assert outputs Co-authored-by: Dan Knutsen <dmknutsen@users.noreply.github.com> Co-authored-by: Joseph Hickey <jphickey@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist (Please check before submitting)
Describe the contribution
File permissions in general are a POSIX concept, but this tool should be pure C99. It should not rely on any POSIX headers or POSIX-specific API calls.
Fixes #1300
Testing performed
Build and run tests
Expected behavior changes
No more build failures
System(s) tested on
Ubuntu 22.04
Additional context
Setting permissions explicitly is not really necessary.
Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.