Fix #1370, workflow to validate OSAL API #1372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a new build and test workflow that includes an API validation with both C and C++ compilers. This should catch any cases where syntactical elements that work in C but do not work in C++ appear in the headers.
jphickey
force-pushed
the
fix-1370-validate-api
branch
from
45f6e40
to
bb49702
Compare
dzbaker
added
the
CCB:Approved
dzbaker
added a commit
to nasa/cFS
that referenced
this pull request
Mar 2, 2023
*Combines:* osal v6.0.0-rc4+dev205 **Includes:** *osal* - nasa/osal#1371 - nasa/osal#1372 Co-authored by: Joseph Hickey <jphickey@users.noreply.github.com>
This was referenced Mar 2, 2023
dzbaker
added a commit
to nasa/cFS
that referenced
this pull request
Mar 2, 2023
*Combines:* osal v6.0.0-rc4+dev205 **Includes:** *osal* - nasa/osal#1371 - nasa/osal#1372 Co-authored by: Joseph Hickey <jphickey@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist (Please check before submitting)
Describe the contribution
Adds a new build and test workflow that includes an API validation with both C and C++ compilers. This should catch any cases where syntactical elements that work in C but do not work in C++ appear in the headers.
Fixes #1370
Testing performed
Build and run workflow
Expected behavior changes
OSAL API headers will now be checked against a C++ compiler.
System(s) tested on
Github workflow
Additional context
Note that due to #1365, this currently fails (thus validating that this workflow is catching what it is supposed to). Once the fix is merged, this should pass.
Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.