Integration Candidate COMBINED 2020-04-29 and 2020-05-06 #458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deprecate the OStask_ID field within the property structure. Replace with a new API to perform a task ID reverse-lookup based on an abstract data object (the system task ID).
Resize buffers and tweak string copies to avoid truncation warnings in GCC 9. Note the code was generally OK (handled truncation) but the new compiler still generates warnings even with correct usage of certain functions. In the UT_os_printf macro, be sure to "use" the return value of the snprintf() call, which avoids warnings about truncation.
Fix #437, Add new API for obtaining exception task ID
Fix #435, fix string manipulations to avoid warnings
Tidy up readme markdown
jphickey
pushed a commit
to jphickey/osal
that referenced
this pull request
Aug 10, 2022
Use SRC_LOCAL_PATH as single source of truth
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Fix #437, add new API for obtaining exception task ID
Fix #435, Changes for string ops warnings
Testing performed
See PRs
Bundle CI - https://travis-ci.com/github/nasa/cFS/builds/165726730
Expected behavior changes
PR #441 - Resized buffers and added explicit termination to string copies. No warnings on GCC9 with strict settings and optimization enabled.
PR #446 - New API to reverse lookup an OS-provided thread/task identifier back to an OSAL ID.
Any use of existing OStask_id field within the task property structure is now deprecated.
System(s) tested on
See PRs
Additional context
Part of nasa/cFS#83
Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.