Fix #516, Use absolute timeout for timedlock calls #518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Integration Candidate 2020-06-10
Fast Track for Integration Candidate 2020-06-10
The pthread API defines the timeout parameter for the pthread_mutex_timedlock call as an absolute value based on CLOCK_REALTIME. This introduces a wrapper function to calculate the absolute timeout for this.
jphickey
added
the
CCB:Ready
|
@skliper and @astrogeco - this might be considered for fast track or at least I'd recommend getting this into the branch for the upcoming bundle release in addition to "master" branch. |
skliper
approved these changes
Jun 22, 2020
astrogeco
added
CCB-20200624
and removed
CCB:Ready
jphickey
pushed a commit
to jphickey/osal
that referenced
this pull request
Aug 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the contribution
The pthread API defines the timeout parameter for the pthread_mutex_timedlock call as an absolute value based on CLOCK_REALTIME.
This introduces a wrapper function to calculate the absolute timeout for this.
Fixes #516
Testing performed
Build and execute CFE, sanity check CFE operation, and run all unit tests.
Coverage is not affected because there is no coverage test for POSIX.
Expected behavior changes
The timed lock in binary semaphores should now correctly wait for up to 2 seconds for the lock to become available before failing. The net effect of passing a relative timeout in place of an absolute one meant that the code would not wait, basically turning into a "trylock" instead.
System(s) tested on
Ubuntu 20.04
Additional context
Unfortunately this wasn't previously noticed during testing because it requires getting two tasks to operate on the same binary sem at exactly the same time, which is difficult to replicate.
Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.