Fix #586, Add one shot timer functional test #653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skliper
approved these changes
Nov 12, 2020
|
Amend commit - "Fix #586, Add one-shot timer functional test" |
zanzaben
added
the
CCB:Ready
|
CCB 2020-11-12 |
|
Recommend squash and amend - "Fix #586, Add one-shot timer functional test" |
zanzaben
force-pushed
the
fix586-one-shot-time-test
branch
from
0e769f8
to
4a9a4b7
Compare
astrogeco
added
CCB-20201112
and removed
CCB:Ready
|
@zanzaben please revise conflict, I think it just needs a type change from |
zanzaben
force-pushed
the
fix586-one-shot-time-test
branch
from
4a9a4b7
to
43d6e3b
Compare
skliper
changed the title
zanzaben
force-pushed
the
fix586-one-shot-time-test
branch
from
43d6e3b
to
720c767
Compare
|
What happened is that there was a functional test that used a list of 4 different timers. I added a 5th timer to that list to test the one shot case. |
|
@astrogeco I'm good with it but feel free to suggest anything you'd like to have added |
|
Just added zanzaben's comment to the description along with my simple definition of one-shot. #learningthelingo |
astrogeco
added a commit
to astrogeco/cFS
that referenced
this pull request
Dec 1, 2020
astrogeco
added a commit
to astrogeco/cFS
that referenced
this pull request
Dec 2, 2020
jphickey
pushed a commit
to jphickey/osal
that referenced
this pull request
Aug 10, 2022
Fix nasa#411, rework exception handling in CFE
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Fixes #586, added a one shot timer.
Added a 5th timer to functional test to test the one shot (zero-length time interval) case.
Testing performed
Build and run unit test.
Expected behavior changes
No behavior change
System(s) tested on
Ubuntu 20.04
Contributor Info - All information REQUIRED for consideration of pull request
Alex Campbell GSFC