Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #655, use 3 argument form of open #656

Merged

Conversation

jphickey
Copy link
Contributor

Describe the contribution
VxWorks only provides the 3 argument form of open(). Passing 0 as the mode solves the build issue. This parameter is ignored when not creating a file.

Fixes #655

Testing performed
Build and sanity check CFE

Expected behavior changes
No behavior change. Fixes build issue on VxWorks 6.9

System(s) tested on
VxWorks 6.9

Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.

@jphickey jphickey added the CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) label Nov 17, 2020
@skliper
Copy link
Contributor

skliper commented Nov 17, 2020

Ping @excaliburtb

@skliper skliper added this to the 6.0.0 milestone Nov 17, 2020
@astrogeco
Copy link
Contributor

CCB 2020-11-18 APPROVED

@skliper
Copy link
Contributor

skliper commented Nov 30, 2020

@astrogeco Is it possible to fasttrack this? Impacts stakeholders.

@astrogeco astrogeco changed the base branch from main to integration-candidate December 1, 2020 16:46
@astrogeco astrogeco added IC-20201124 and removed CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) labels Dec 1, 2020
@astrogeco astrogeco merged commit a8f0695 into nasa:integration-candidate Dec 1, 2020
astrogeco added a commit to astrogeco/cFS that referenced this pull request Dec 1, 2020
astrogeco added a commit to astrogeco/cFS that referenced this pull request Dec 2, 2020
@jphickey jphickey deleted the fix-655-vxworks-open branch December 3, 2020 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

VxWorks build failure in OS_FileChmod_Impl
3 participants