Fix #574, Document UtAssert_Message parameters #713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skliper
added
unit-test
|
Ping @asgibson - do you have a use case for calling this directly? Expectation in test cases is to use the UtPrintf and UtDebug helper marcos. |
jphickey
approved these changes
Dec 29, 2020
|
I do not think I had a use case in mind when I found it. I was looking to solve a problem which ended up unrelated to this and happened to notice it. After looking at the other message types defined, I also see no reason for this to be available to unit testers. The only level above the two defined that you mentioned is the default, "OTHER". |
asgibson
approved these changes
Dec 30, 2020
jphickey
pushed a commit
to jphickey/osal
that referenced
this pull request
Aug 10, 2022
Fix nasa#603, Full context info for EVS event stubs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Fix #574 - document UtAssert_Message parameters, also adds see also for helper macros
Testing performed
CI, comment change only.
Expected behavior changes
None
System(s) tested on
N/A
Additional context
Worth considering making this internal, no identified use case for direct call. Would be confusing to output any message other than info/debug.
Third party code
None.
Contributor Info - All information REQUIRED for consideration of pull request
Jacob Hageman - NASA/GSFC