Fix #785, Clean commented out code #786
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skliper
added
the
unit-test
zanzaben
approved these changes
Feb 10, 2021
jphickey
approved these changes
Feb 12, 2021
jphickey
pushed a commit
to jphickey/osal
that referenced
this pull request
Aug 10, 2022
…chain Fix nasa#785, update vxworks 6.9 example toolchain
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Fix #785 - cleans commented out code (all from test code)
Testing performed
Build/execute unit test, passes
Expected behavior changes
None, just avoids static analysis warnings
System(s) tested on
Additional context
Would really benefit from ASSERT macro in cFE... maybe consider moving/consolidating these general macros? Almost all the debug code that was commented out would be better replaced by ASSERT.
Third party code
None
Contributor Info - All information REQUIRED for consideration of pull request
Jacob Hageman - NASA/GSFC