Fix #803, Add check of semaphore to avoid unreachable code in posix OS_BinSemCreate_Impl #804
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ix OS_BinSemCreate_Impl
jphickey
approved these changes
Feb 12, 2021
jphickey
pushed a commit
to jphickey/osal
that referenced
this pull request
Aug 10, 2022
Fix nasa#778, Add CFE_Assert library and test module
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Fix #803 - adds a check to send the semaphore to avoid unreachable code, basically a non-op placeholder to avoid refactoring unreachable code which would make it less future-proof
Testing performed
Build and execute unit tests, passed
Expected behavior changes
None, avoids static analysis warning and uncoverable code
System(s) tested on
Additional context
Eventually when coverage is added to posix this will help meet the 100% goal
Third party code
None
Contributor Info - All information REQUIRED for consideration of pull request
Jacob Hageman - NASA/GSFC