Fix #964, UtPrintx function #973
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix the UtPrintx() routine such that the loop stops correctly. Also improves the output to print the address, not just the data. Note if UtPrintf is used, one sees the file/line of the UtPrintx function, not the actual test location, so it is better to call UT_BSP_DoText directly so it omits this extraneous info.
jphickey
added
the
CCB:Ready
skliper
approved these changes
Apr 27, 2021
|
CCB:2021-04-28 APPROVED |
astrogeco
added
CCB:Approved
|
The branch was deleted by mistake, this is still needing merge |
astrogeco
added a commit
to nasa/cFS
that referenced
this pull request
May 5, 2021
nasa/osal#973, UtPrintx function nasa/osal#976, add socket shutdown implementation
astrogeco
added a commit
to nasa/cFS
that referenced
this pull request
May 5, 2021
cfe v6.8.0-rc1+dev559 and osal v5.1.0-rc1+dev417 Combines: nasa/osal#979 nasa/cFE#1481 Includes: nasa/osal#973, UtPrintx function nasa/osal#976, add socket shutdown implementation nasa/cFE#1418, add ES CDS Functional test nasa/cFE#1429, Function comment blocks nasa/cFE#1414, Add Header Functional tests. nasa/cFE#1415, add Current Time Functional Test
jphickey
pushed a commit
to jphickey/osal
that referenced
this pull request
Aug 10, 2022
jphickey
pushed a commit
to jphickey/osal
that referenced
this pull request
Aug 10, 2022
Fix nasa#973, CFE_MSG_Init clear option removed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Fix the UtPrintx() routine such that the loop stops correctly. Also improves the output to print the address, not just the data.
Note if UtPrintf is used, one sees the file/line of the UtPrintx function, not the actual test location, so it is better to call
UT_BSP_DoText directly so it omits this extraneous info.
Fixes #964
Testing performed
Temporarily Update a test to use UtPrintx() -- this function was not used in any current tests -- and confirm that the output now works as expected.
Expected behavior changes
No infinite loop in UtPrintx, and also it now includes the memory address of the data, not just the data itself.
System(s) tested on
Ubuntu 20.04
Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey Vantage Systems, Inc.