Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unit tests need to link with UT_COVERAGE_COMPILE_FLAGS/UT_COVERAGE_LINK_FLAGS #19

Closed
jphickey opened this issue Apr 14, 2020 · 0 comments · Fixed by #20 or #22
Closed

Unit tests need to link with UT_COVERAGE_COMPILE_FLAGS/UT_COVERAGE_LINK_FLAGS #19

jphickey opened this issue Apr 14, 2020 · 0 comments · Fixed by #20 or #22
Labels
bug Something isn't working build-system unit-test
Milestone
Bootes

Comments

@jphickey
Copy link
Contributor

Is your feature request related to a problem? Please describe.
nasa/osal#404 cleans up the compiler flag management, and as part of this it exports two variables, UT_COVERAGE_COMPILE_FLAGS and UT_COVERAGE_LINK_FLAGS, rather than a single UT_C_FLAGS value.

Describe the solution you'd like
The unit tests need to use these variables, not UT_C_FLAGS.

Additional context
Needs to be included with the nasa/osal#404 merge.

Requester Info
Joseph Hickey, Vantage Systems, Inc.
jphickey added a commit to jphickey/sample_lib that referenced this issue Apr 14, 2020
@jphickey
Fix nasa#19, Update coverage compile/link flag options
78edacf 
OSAL now sets these as UT_COVERAGE_COMPILE_FLAGS, UT_COVERAGE_LINK_FLAGS.
Building and linking the UT executable needs a corresponding update.
@jphickey jphickey mentioned this issue Apr 14, 2020
Merged
astrogeco added a commit that referenced this issue Apr 28, 2020
@astrogeco
Merge pull request #20 from jphickey/fix-19-ut-coverage-flags
b93753b 
Fix #19, Update coverage compile/link flag options
@astrogeco astrogeco mentioned this issue May 1, 2020
Merged
@astrogeco astrogeco added this to the 1.2.0 milestone Oct 1, 2020
@astrogeco astrogeco added unit-test bug Something isn't working build-system labels Oct 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working build-system unit-test
Projects
None yet
Milestone
Bootes
2 participants
@jphickey @astrogeco