Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commands flags with quoted parameters lose flags. #177

Closed
joshriverscambia2019 opened this issue Oct 25, 2023 · 2 comments
Closed

Commands flags with quoted parameters lose flags. #177

joshriverscambia2019 opened this issue Oct 25, 2023 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@joshriverscambia2019
Copy link

When you define a command task with a flag parameter with an equals sign and a quoted operand, the flag is omitted from the command execution.

For example, the task:

foo = "ls --color='always'"

Will output:

% poetry run poe foo
Poe => ls always
ls: always: No such file or directory

While one would expect:

% poetry run poe foo
Poe => ls --color=always
README.md      pyproject.toml

This problem began with v0.23.0. It seems likely that the issue is that the resolve_command_tokens function is losing data in token_parts variable when it is re-initialized within this loop.

@nat-n nat-n added the bug Something isn't working label Oct 25, 2023
@nat-n
Copy link
Owner

nat-n commented Oct 25, 2023

Hi @joshriverscambia2019

Thanks for the feedback :) yep that's a bug in the new cmd parsing logic! I'll get a fix for that out soon :)

@nat-n nat-n self-assigned this Oct 25, 2023
nat-n added a commit that referenced this issue Oct 25, 2023
nat-n added a commit that referenced this issue Oct 25, 2023
nat-n added a commit that referenced this issue Nov 4, 2023
nat-n added a commit that referenced this issue Nov 4, 2023
@nat-n
Copy link
Owner

nat-n commented Nov 4, 2023

Thanks again for reporting this bug. It's now fixed with v0.24.2 🚀

@nat-n nat-n closed this as completed Nov 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants