-
-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow changing default verbosity. #34
Allow changing default verbosity. #34
Conversation
For example, setting: [tool.poe] verbosity = -1 Will make all commands quiet unless --verbose is passed.
Three tests fail and I get two type checking errors, but that also happens on the previous commit so I'm assuming it's not something I've done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Artemis21, thanks for the contribution. Nicely done.
I think it would make sense to also support this option at the task level, though it's not necessary for now.
Fortunately all tests pass in CI :) Out of curiosity, which ones fail for you?
I'm happy to merge and create another prerelease for this, if you could just update the version number as advised. 0.11.0 is set to be a big one, I just need to find time to finish testing of some of the prerelease features.
Actually never mind, I fixed the version myself. Et voila https://pypi.org/project/poethepoet/0.11.0b4/ |
Cool! Mypy gives:
Both look fine to me though so not sure why. |
I'll have a look at implementing that. Another nice feature would be the ability to set normal verbosity from the command line - passing neither The simplest way to do that would be to add a third option, like A more generic way would be to have an option that allows you to set the level directly, eg. An approach users may be more familiar with would be to make |
I like the model of Though adding a |
For example, setting:
Will make all commands quiet unless --verbose is passed.