Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ignore_fail option to return non-zero exit status from sequence #40

Merged

Conversation

tsimoshka
Copy link
Contributor

Allow two addition option value for ingore_fail option:

  • "return_zero": works like true
  • "return_non_zero": run all the subtasks regardless theirs exit status, but returns non-zero exit status if any of subtasks failed

#39

Allow two addition option value for `ingore_fail` option:
- `return_zero`: works like true
- `return_non_zero`: run all the subtasks regardless theirs exit status,
but returns non-zero exit status if any of subtasks failed
Copy link
Owner

@nat-n nat-n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution, LGTM 👍

The fixture for generating pyproject.toml files is a nice touch.

@nat-n nat-n merged commit ec4e2cf into nat-n:development Oct 26, 2021
cigani pushed a commit to cigani/poethepoet that referenced this pull request Nov 2, 2021
…ence (nat-n#40)

Allow two addition option value for `ingore_fail` option:
- `return_zero`: works like true
- `return_non_zero`: run all the subtasks regardless theirs exit status,
but returns non-zero exit status if any of subtasks failed
ThatXliner pushed a commit to ThatXliner/poethepoet that referenced this pull request Dec 24, 2021
…ence (nat-n#40)

Allow two addition option value for `ingore_fail` option:
- `return_zero`: works like true
- `return_non_zero`: run all the subtasks regardless theirs exit status,
but returns non-zero exit status if any of subtasks failed
ThatXliner pushed a commit to ThatXliner/poethepoet that referenced this pull request Dec 24, 2021
…ence (nat-n#40)

Allow two addition option value for `ingore_fail` option:
- `return_zero`: works like true
- `return_non_zero`: run all the subtasks regardless theirs exit status,
but returns non-zero exit status if any of subtasks failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants