Remove authenticode signing of binaries and packages (#143)

natemcmaster · Jun 28, 2020 · 467fc10 · 467fc10
1 parent 4930145
commit 467fc10
Show file tree

Hide file tree

Showing 7 changed files with 0 additions and 94 deletions.
diff --git a/.config/dotnet-tools.json b/.config/dotnet-tools.json
diff --git a/Directory.Build.props b/Directory.Build.props
@@ -22,10 +22,6 @@
     <Nullable Condition="'$(TargetFramework)' == 'netcoreapp3.0'">enable</Nullable>
     <AssemblyOriginatorKeyFile>$(MSBuildThisFileDirectory)src\StrongName.snk</AssemblyOriginatorKeyFile>
     <SignAssembly>true</SignAssembly>
-    <AzureKeyVaultUrl>https://nmcmaster.vault.azure.net</AzureKeyVaultUrl>
-    <AzureKeyVaultClientId>6a27a2da-bb78-4baa-bd2b-150fe89ea039</AzureKeyVaultClientId>
-    <AzureKeyVaultClientSecret>$(KEYVAULT_CLIENT_SECRET)</AzureKeyVaultClientSecret>
-    <CodeSignCertName>DigiCertCodeSign</CodeSignCertName>
     <NoWarn>$(NoWarn);NU5105</NoWarn>
     <WarningsNotAsErrors>$(WarningsNotAsErrors);1591</WarningsNotAsErrors>
 

diff --git a/DotNetCorePlugins.sln b/DotNetCorePlugins.sln
@@ -44,7 +44,6 @@ Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "Solution Items", "Solution
 		.editorconfig = .editorconfig
 		.gitignore = .gitignore
 		build.ps1 = build.ps1
-		src\CodeSign.targets = src\CodeSign.targets
 		src\common.psm1 = src\common.psm1
 		Directory.Build.props = Directory.Build.props
 		Directory.Build.targets = Directory.Build.targets

diff --git a/azure-pipelines.yml b/azure-pipelines.yml
@@ -5,7 +5,6 @@ pr:
 - '*'
 
 variables:
-- group: AzureKeyVault
 - name: BuildNumber
   value: $[counter('buildnumber')]
 
@@ -34,8 +33,6 @@ jobs:
       packageType: runtime
   - powershell: ./build.ps1 -ci
     displayName: Invoke build.ps1
-    env:
-      KEYVAULT_CLIENT_SECRET: $(kv-access-token)
   - task: PublishTestResults@2
     displayName: Upload test results
     condition: always()

diff --git a/build.ps1 b/build.ps1
@@ -5,8 +5,6 @@ param(
     $Configuration = $null,
     [switch]
     $ci,
-    [switch]
-    $sign,
     [Parameter(ValueFromRemainingArguments = $true)]
     [string[]]$MSBuildArgs
 )
@@ -32,13 +30,6 @@ if (-not (Test-Path variable:\IsCoreCLR)) {
     $IsWindows = $true
 }
 
-$isPr = $env:BUILD_REASON -eq 'PullRequest'
-$CodeSign = $sign -or ($ci -and -not $isPr -and $IsWindows)
-if ($CodeSign) {
-    exec dotnet tool restore
-    $MSBuildArgs += '-p:CodeSign=true'
-}
-
 $artifacts = "$PSScriptRoot/artifacts/"
 
 Remove-Item -Recurse $artifacts -ErrorAction Ignore

diff --git a/src/CodeSign.targets b/src/CodeSign.targets
diff --git a/src/Directory.Build.targets b/src/Directory.Build.targets
@@ -14,6 +14,4 @@
     <Message Importance="High" Text="##vso[build.updatebuildnumber]$(PackageVersion)" />
   </Target>
 
-  <Import Project="CodeSign.targets" />
-
 </Project>