Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove authenticode signing of binaries and packages #143

Merged
merged 1 commit into from
Jun 28, 2020
Merged

Remove authenticode signing of binaries and packages #143

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Remove authenticode signing of binaries and packages
  • Loading branch information
@natemcmaster
natemcmaster committed Jun 28, 2020
commit 4b253c4ad1da617a9b08ec37cf442953b010695f
18 changes: 0 additions & 18 deletions .config/dotnet-tools.json
View file
Open in desktop

This file was deleted.

4 changes: 0 additions & 4 deletions Directory.Build.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,10 +22,6 @@
<Nullable Condition="'$(TargetFramework)' == 'netcoreapp3.0'">enable</Nullable>
<AssemblyOriginatorKeyFile>$(MSBuildThisFileDirectory)src\StrongName.snk</AssemblyOriginatorKeyFile>
<SignAssembly>true</SignAssembly>
<AzureKeyVaultUrl>https://nmcmaster.vault.azure.net</AzureKeyVaultUrl>
<AzureKeyVaultClientId>6a27a2da-bb78-4baa-bd2b-150fe89ea039</AzureKeyVaultClientId>
<AzureKeyVaultClientSecret>$(KEYVAULT_CLIENT_SECRET)</AzureKeyVaultClientSecret>
<CodeSignCertName>DigiCertCodeSign</CodeSignCertName>
<NoWarn>$(NoWarn);NU5105</NoWarn>
<WarningsNotAsErrors>$(WarningsNotAsErrors);1591</WarningsNotAsErrors>

Expand Down
1 change: 0 additions & 1 deletion DotNetCorePlugins.sln
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,6 @@ Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "Solution Items", "Solution
.editorconfig = .editorconfig
.gitignore = .gitignore
build.ps1 = build.ps1
src\CodeSign.targets = src\CodeSign.targets
src\common.psm1 = src\common.psm1
Directory.Build.props = Directory.Build.props
Directory.Build.targets = Directory.Build.targets
Expand Down
3 changes: 0 additions & 3 deletions azure-pipelines.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ pr:
- '*'

variables:
- group: AzureKeyVault
- name: BuildNumber
value: $[counter('buildnumber')]

Expand Down Expand Up @@ -34,8 +33,6 @@ jobs:
packageType: runtime
- powershell: ./build.ps1 -ci
displayName: Invoke build.ps1
env:
KEYVAULT_CLIENT_SECRET: $(kv-access-token)
- task: PublishTestResults@2
displayName: Upload test results
condition: always()
Expand Down
9 changes: 0 additions & 9 deletions build.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,6 @@ param(
$Configuration = $null,
[switch]
$ci,
[switch]
$sign,
[Parameter(ValueFromRemainingArguments = $true)]
[string[]]$MSBuildArgs
)
Expand All @@ -32,13 +30,6 @@ if (-not (Test-Path variable:\IsCoreCLR)) {
$IsWindows = $true
}

$isPr = $env:BUILD_REASON -eq 'PullRequest'
$CodeSign = $sign -or ($ci -and -not $isPr -and $IsWindows)
if ($CodeSign) {
exec dotnet tool restore
$MSBuildArgs += '-p:CodeSign=true'
}

$artifacts = "$PSScriptRoot/artifacts/"

Remove-Item -Recurse $artifacts -ErrorAction Ignore
Expand Down
57 changes: 0 additions & 57 deletions src/CodeSign.targets
View file
Open in desktop

This file was deleted.

2 changes: 0 additions & 2 deletions src/Directory.Build.targets
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,4 @@
<Message Importance="High" Text="##vso[build.updatebuildnumber]$(PackageVersion)" />
</Target>

<Import Project="CodeSign.targets" />

</Project>