Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump golang crypto package #23

Merged
merged 1 commit into from
Mar 30, 2020

Conversation

KauzClay
Copy link
Contributor

  • In response to a recent CVE, we would
    like to bump the cryto package to contain this
    fix

cc @ameowlia @adobley @bruce-ricard

* In response to a recent [CVE](https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2020-9283), we would
like to bump the cryto package to contain this
[fix](golang/crypto@bac4c82f6975)

cc @ameowlia @adobley @bruce-ricard
@coveralls
Copy link

Pull Request Test Coverage Report for Build 99

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 83.019%

Totals Coverage Status
Change from base Build 97: 0.0%
Covered Lines: 264
Relevant Lines: 318

💛 - Coveralls

1 similar comment
@coveralls
Copy link

Pull Request Test Coverage Report for Build 99

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 83.019%

Totals Coverage Status
Change from base Build 97: 0.0%
Covered Lines: 264
Relevant Lines: 318

💛 - Coveralls

Copy link
Member

@kozlovic kozlovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we remove the go 1.14? I know it gets put there whenever you build from go 1.13+, but I still don't get why they had this.
Also, please do a go mod tidy so that it removes from the go.sum the references to the old crypto commit hashes.

Copy link
Member

@kozlovic kozlovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We would like to do a release of the NATS Server that depends on this. So I will merge this and have another update if needed to do the tidy, etc..
Thanks for the contribution!

@kozlovic kozlovic merged commit 2876619 into nats-io:master Mar 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants