Skip to content

Commit

Permalink
Shape up prework (learn-co-curriculum#6)
Browse files Browse the repository at this point in the history
* update readme for new sequencing

* update gh workflow to remove prework flag
  • Loading branch information
lizbur10 committed Dec 17, 2021
1 parent cd7d0d7 commit 77a68cd
Show file tree
Hide file tree
Showing 3 changed files with 16 additions and 33 deletions.
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
name: Sync with Canvas Pre-Work that Contains HTML
name: Sync with Canvas HTML

on:
push:
Expand All @@ -25,7 +25,7 @@ jobs:

# Secret stored in learn-co-curriculum Settings/Secrets
- name: Sync from .canvas file
run: github-to-canvas -a -lr --forkable --prework --contains-html
run: github-to-canvas -a -lr --forkable --contains-html
env:
CANVAS_API_KEY: ${{ secrets.CANVAS_API_KEY }}
CANVAS_API_PATH: ${{ secrets.CANVAS_API_PATH }}
44 changes: 14 additions & 30 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,7 @@ them.
If you haven't already, fork and clone this lab into your local environment.
Navigate into its directory in the terminal, then run `code .` to open the files
in Visual Studio Code. (If you are using a different text editor, the command
will be different.) Finally, run `npm install` to install the lab's
dependencies.
will be different.)

### Code-Along

Expand Down Expand Up @@ -85,11 +84,11 @@ per function, but let's start with this one.

### Running the Tests

To run the tests, run `npm test` in the terminal. The first output you'll see
will look like this:
To run the tests, run `learn test` in the terminal. The first output you'll see
will look something like this:

```console
$ npm test
$ learn test
> java-script-intro-to-functions-lab@0.1.0 test
> mocha --timeout 5000 --reporter 'json' > .results.json & mocha

Expand All @@ -113,50 +112,51 @@ $ npm test
7) returns "I would love to!" if `string` is "Let's have dinner together!"`


0 passing (133ms)
0 passing (120ms)
7 failing

1) shout(string)
receives one argument and returns it in all caps:
ReferenceError: shout is not defined
at Context.<anonymous> (test/index-test.js:4:5)
at processImmediate (node:internal/timers:464:21)
at processImmediate (internal/timers.js:461:21)

2) whisper(string)
receives one argument and returns it in all lowercase:
ReferenceError: whisper is not defined
at Context.<anonymous> (test/index-test.js:10:5)
at processImmediate (node:internal/timers:464:21)
at processImmediate (internal/timers.js:461:21)

3) logShout(string)
takes a string argument and logs it in all caps using console.log():
ReferenceError: logShout is not defined
at Context.<anonymous> (test/index-test.js:18:5)
at processImmediate (node:internal/timers:464:21)
at processImmediate (internal/timers.js:461:21)

4) logWhisper(string)
takes a string argument and logs it in all lowercase using console.log():
ReferenceError: logWhisper is not defined
at Context.<anonymous> (test/index-test.js:30:5)
at processImmediate (node:internal/timers:464:21)
at processImmediate (internal/timers.js:461:21)

5) sayHiToHeadphonedRoommate(string)
returns "I can't hear you!" if `string` is lowercase:
ReferenceError: sayHiToHeadphonedRoommate is not defined
at Context.<anonymous> (test/index-test.js:40:5)
at processImmediate (node:internal/timers:464:21)
at processImmediate (internal/timers.js:461:21)

6) sayHiToHeadphonedRoommate(string)
returns "YES INDEED!" if `string` is uppercase:
ReferenceError: sayHiToHeadphonedRoommate is not defined
at Context.<anonymous> (test/index-test.js:44:5)
at processImmediate (node:internal/timers:464:21)
at processImmediate (internal/timers.js:461:21)

7) sayHiToHeadphonedRoommate(string)
returns "I would love to!" if `string` is "Let's have dinner together!"`:
ReferenceError: sayHiToHeadphonedRoommate is not defined
at Context.<anonymous> (test/index-test.js:48:5)
at processImmediate (node:internal/timers:464:21)
at processImmediate (internal/timers.js:461:21)

```

Hm, seven failed tests. Let's see if we can get that _first_ test to
Expand Down Expand Up @@ -295,7 +295,7 @@ and run our tests again. We get:
returns "I would love to!" if `string` is "Let's have dinner together!"`:
ReferenceError: sayHiToHeadphonedRoommate is not defined
at Context.<anonymous> (test/index-test.js:48:5)
at processImmediate (node:internal/timers:464:21)
at processImmediate (internal/timers.js:456:21)
```

Hey! We got one to pass! Six left.
Expand Down Expand Up @@ -382,19 +382,3 @@ tests, however, you don't need to include a function call — the tests will
handle that for you.

Good luck!

## Saving Your Work Remotely

Currently, the work you've done on this assignment is only on your local
machine. To preserve your solution on your GitHub fork, you will need to stage
the changes you've made, commit them, and push the commit up to GitHub. Use the
following commands to do this:

```console
$ git add .
$ git commit -m "Completed assignment"
$ git push
```

If you visit your fork on GitHub, you should now see that _you've_ made the most
recent commit, and your code will be present in the files.
1 change: 0 additions & 1 deletion index.js
Original file line number Diff line number Diff line change
@@ -1 +0,0 @@
// your code here

0 comments on commit 77a68cd

Please sign in to comment.