Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release/5.7 #630

Merged
merged 89 commits into from
Feb 2, 2020
Merged

release/5.7 #630

merged 89 commits into from
Feb 2, 2020

Conversation

x4v13r64
Copy link
Collaborator

@x4v13r64 x4v13r64 commented Jan 31, 2020

Changes:

Warning this implements backward-incompatible changes to:

  • Azure CLI options
  • Azure partials

zscholl and others added 30 commits December 2, 2019 08:25
Enhancement/Improved test coverage
# Conflicts:
#	ScoutSuite/providers/azure/provider.py
#	ScoutSuite/providers/gcp/resources/kms/keyrings.py
Add new SSL/TLS security policies
# Conflicts:
#	ScoutSuite/providers/azure/rules/findings/securitycenter-auto-provisioning-off.json
#	ScoutSuite/providers/azure/rules/findings/securitycenter-security-contacts-email-not-set.json
#	ScoutSuite/providers/azure/rules/findings/securitycenter-security-contacts-no-admin-email-notifications.json
#	ScoutSuite/providers/azure/rules/findings/securitycenter-security-contacts-no-email-notifications.json
#	ScoutSuite/providers/azure/rules/findings/securitycenter-security-contacts-phone-not-set.json
#	ScoutSuite/providers/azure/rules/findings/securitycenter-standard-tier-not-enabled.json
#	ScoutSuite/providers/azure/rules/findings/sqldatabase-databases-auditing-low-retention.json
#	ScoutSuite/providers/azure/rules/findings/sqldatabase-databases-no-auditing.json
#	ScoutSuite/providers/azure/rules/findings/sqldatabase-databases-no-threat-detection.json
#	ScoutSuite/providers/azure/rules/findings/sqldatabase-databases-no-transparent-data-encryption.json
#	ScoutSuite/providers/azure/rules/findings/sqldatabase-databases-threat-detection-disabled-alerts.json
#	ScoutSuite/providers/azure/rules/findings/sqldatabase-databases-threat-detection-low-retention.json
#	ScoutSuite/providers/azure/rules/findings/sqldatabase-servers-auditing-low-retention.json
#	ScoutSuite/providers/azure/rules/findings/sqldatabase-servers-no-ad-admin-configured.json
#	ScoutSuite/providers/azure/rules/findings/sqldatabase-servers-no-auditing.json
#	ScoutSuite/providers/azure/rules/findings/sqldatabase-servers-no-threat-detection.json
#	ScoutSuite/providers/azure/rules/findings/sqldatabase-servers-threat-detection-disabled-alerts.json
#	ScoutSuite/providers/azure/rules/findings/sqldatabase-servers-threat-detection-low-retention.json
#	ScoutSuite/providers/azure/rules/findings/storageaccount-access-keys-not-rotated.json
#	ScoutSuite/providers/azure/rules/findings/storageaccount-account-allowing-clear-text.json
#	ScoutSuite/providers/azure/rules/findings/storageaccount-public-blob-container.json
#	ScoutSuite/providers/azure/rules/findings/storageaccount-trusted-microsoft-services.json
# Conflicts:
#	ScoutSuite/providers/azure/rules/findings/graphrbac-guest-users.json
#	ScoutSuite/providers/azure/rules/findings/securitycenter-auto-provisioning-off.json
#	ScoutSuite/providers/azure/rules/findings/securitycenter-security-contacts-email-not-set.json
#	ScoutSuite/providers/azure/rules/findings/securitycenter-security-contacts-no-admin-email-notifications.json
#	ScoutSuite/providers/azure/rules/findings/securitycenter-security-contacts-no-email-notifications.json
#	ScoutSuite/providers/azure/rules/findings/securitycenter-security-contacts-phone-not-set.json
#	ScoutSuite/providers/azure/rules/findings/securitycenter-standard-tier-not-enabled.json
#	ScoutSuite/providers/azure/rules/findings/sqldatabase-databases-auditing-low-retention.json
#	ScoutSuite/providers/azure/rules/findings/sqldatabase-databases-no-auditing.json
#	ScoutSuite/providers/azure/rules/findings/sqldatabase-databases-no-threat-detection.json
#	ScoutSuite/providers/azure/rules/findings/sqldatabase-databases-no-transparent-data-encryption.json
#	ScoutSuite/providers/azure/rules/findings/sqldatabase-databases-threat-detection-disabled-alerts.json
#	ScoutSuite/providers/azure/rules/findings/sqldatabase-databases-threat-detection-low-retention.json
#	ScoutSuite/providers/azure/rules/findings/sqldatabase-servers-auditing-low-retention.json
#	ScoutSuite/providers/azure/rules/findings/sqldatabase-servers-no-ad-admin-configured.json
#	ScoutSuite/providers/azure/rules/findings/sqldatabase-servers-no-auditing.json
#	ScoutSuite/providers/azure/rules/findings/sqldatabase-servers-no-threat-detection.json
#	ScoutSuite/providers/azure/rules/findings/sqldatabase-servers-threat-detection-disabled-alerts.json
#	ScoutSuite/providers/azure/rules/findings/sqldatabase-servers-threat-detection-low-retention.json
#	ScoutSuite/providers/azure/rules/findings/storageaccount-access-keys-not-rotated.json
#	ScoutSuite/providers/azure/rules/findings/storageaccount-account-allowing-clear-text.json
#	ScoutSuite/providers/azure/rules/findings/storageaccount-public-blob-container.json
#	ScoutSuite/providers/azure/rules/findings/storageaccount-trusted-microsoft-services.json
@codecov-io
Copy link

codecov-io commented Jan 31, 2020

Codecov Report

Merging #630 into master will decrease coverage by 0.36%.
The diff coverage is 53.12%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #630      +/-   ##
==========================================
- Coverage   65.32%   64.96%   -0.37%     
==========================================
  Files          22       22              
  Lines        1488     1504      +16     
==========================================
+ Hits          972      977       +5     
- Misses        516      527      +11
Impacted Files Coverage Δ
ScoutSuite/utils.py 85.71% <ø> (ø) ⬆️
ScoutSuite/__main__.py 19.8% <0%> (-0.41%) ⬇️
ScoutSuite/__init__.py 100% <100%> (ø) ⬆️
ScoutSuite/core/cli_parser.py 83.33% <52.94%> (-2.65%) ⬇️
ScoutSuite/core/console.py 65.07% <58.33%> (-2.15%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 03685e9...509f3df. Read the comment docs.

@lgtm-com
Copy link

lgtm-com bot commented Jan 31, 2020

This pull request introduces 2 alerts when merging 509f3df into e784fc2 - view on LGTM.com

new alerts:

  • 1 for Unused local variable
  • 1 for Unused import

@x4v13r64 x4v13r64 merged commit 300a76b into master Feb 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants