Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add ionic framework support #16

Merged
merged 9 commits into from
Sep 27, 2015
Merged

feat: add ionic framework support #16

merged 9 commits into from
Sep 27, 2015

Conversation

Svenskunganka
Copy link
Contributor

Ionic finally added official support for Meteor (see #3133) so decided to add support for it to this generator.

One thing I didn't implement was pagination, search & sort support due to the directive not being fully compatible with Ionic CSS - anyhow, the basics is there.

@Svenskunganka Svenskunganka changed the title feat: added ionic framework support feat: add ionic framework support Sep 25, 2015
@ndxbxrme
Copy link
Owner

Hey Tom
Thanks for your contributions!
I'm getting a few errors when building from your Ionic generator...
image

and when trying to add a new thing to the list
image
which seems to be caused by one of the ionic elements creating it's own child scope
image

fixes it, but seems a bit hacky

@ndxbxrme
Copy link
Owner

Using Coffescript, Jade and Stylus

@Svenskunganka
Copy link
Contributor Author

Hey! Yeah I noticed that now, seemed to be working until the last thing I did was swap out <div ui-view=""></div> with <ion-content ui-view=""></ion-content> so there seem to be some clash between ui-view directive and ion-content directive. Sloppy of me that I didn't notice it right away.

The issue is that if I do <div ui-view=""></div> the ion-content directive inside the view doesn't become scrollable.

I'll commit a fix as soon as I find a workaround

@Svenskunganka
Copy link
Contributor Author

Alright, I've tested as much as I can and I've tackled the error.

The ion-content directive is notorious as f**k, it creates a child scope so any binding in the view has to be referenced by $parent, e.g $parent.things, $parent.form.

Also removed ui-router dep when selecting ionic since ionic already have that as dependency with nice transitions and whatnot.

@ndxbxrme
Copy link
Owner

Cool, I'll give it a test when I finish work

@Svenskunganka
Copy link
Contributor Author

Awesome!

I've actually never worked with CoffeeScript or a Yeoman Generator before so there may be some weird Coffee syntax somewhere. This was fun! 😄

@Svenskunganka
Copy link
Contributor Author

The latest release angular@1.0.0-rc.10 replaced meteor-include directive with blaze-template directive (see #707). urigo:angular-blaze-template dependency had to be added. Applied those changes in this pull as well.

@ndxbxrme
Copy link
Owner

Hey Tom
Looks good. Could you make ionic templates for /generator/route too?

@Svenskunganka
Copy link
Contributor Author

There, completely forgot about the route generator, everything should be in place now for this pull.

@ndxbxrme ndxbxrme merged commit 616e8e1 into ndxbxrme:master Sep 27, 2015
@ndxbxrme
Copy link
Owner

Awesome, I've added it to the generator (v0.18.0)
I did a little tidying up, let me know if I've done anything stupid:)
Thanks for your hard work!

@Svenskunganka
Copy link
Contributor Author

Awesome! I can see now that I missed quite a lot, thanks for covering for me! Overall love this generator, you've done a very nice job!

@Urigo
Copy link

Urigo commented Sep 28, 2015

Wow guys, that's awesome!

@ndxbxrme
Copy link
Owner

Thanks Uri, we're honoured:)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants