remove execute permissions on templates #1798
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmeier
added
needs: review 👀
|
Seems fine, but it'd be nice to run a k8s test, just to be sure. |
|
/bot run tests |
|
Contributor Tests Triggered by @Adam-D-Lewis |
|
/bot run tests |
|
Contributor Tests Triggered by @Adam-D-Lewis |
costrouc
approved these changes
May 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix?
While working on #1778, I reached a state where the exclude in
nebari/.pre-commit-config.yaml
Lines 36 to 37 in 8bd56f9
did not apply. With that,
pre-commitshowed me three files that had execute permissions but no shebang. Given that these are templates and no other template has execute permissions and a shebang, I've just removed the execute permissions here.