Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy Abi into nef file and use nef for scriptHash #378

Closed
wants to merge 7 commits into from

Conversation

shargon
Copy link
Member

@shargon shargon commented Oct 21, 2020

Require neo-project/neo#1973

Require change neo nuget to project reference

superboyiii added a commit to neo-project/neo-node that referenced this pull request Oct 22, 2020
@shargon shargon mentioned this pull request Oct 22, 2020
{
return new NefFile
{
Compiler = "neon",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lost Magic here?

{
nef.Serialize(writer);
}
File.WriteAllBytes(bytesname, nefData);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This nefData lost Magic field.

@shargon
Copy link
Member Author

shargon commented Nov 12, 2020

Closed in favor of #391

@shargon shargon closed this Nov 12, 2020
@shargon shargon deleted the nef-to-abi branch November 12, 2020 18:06
shargon added a commit to neo-project/neo-node that referenced this pull request Dec 1, 2020
* Copy abi to nef

Related: neo-project/neo#1973, neo-project/neo-devpack-dotnet#378

* Update neo-cli/CLI/MainService.cs

* Fix deploy

* fix contract hash (#680)

* update to neo

* Use helper

* Clean usings

Co-authored-by: Shargon <shargon@gmail.com>
Co-authored-by: Vitor Nazário Coelho <vncoelho@gmail.com>
Co-authored-by: Luchuan <luchuan@ngd.neo.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants