Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to use invocation script for contract-based witness verification inside CalculateNetworkFee method #2414

Merged
merged 12 commits into from
Apr 2, 2021

Conversation

shargon
Copy link
Member

@shargon shargon commented Mar 26, 2021

Close #2412

@shargon shargon requested a review from erikzhang March 26, 2021 13:29
@erikzhang
Copy link
Member

Test?

src/neo/Wallets/Wallet.cs Outdated Show resolved Hide resolved
src/neo/Wallets/Wallet.cs Outdated Show resolved Hide resolved
src/neo/Wallets/Wallet.cs Outdated Show resolved Hide resolved
src/neo/Wallets/Wallet.cs Show resolved Hide resolved
AnnaShaleva
AnnaShaleva previously approved these changes Mar 30, 2021
Copy link
Member

@AnnaShaleva AnnaShaleva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice changes, the problem is solved.

AnnaShaleva
AnnaShaleva previously approved these changes Mar 30, 2021
@shargon
Copy link
Member Author

shargon commented Mar 30, 2021

Merge?

@erikzhang
Copy link
Member

@neo-project/ngd-shanghai Please test it.

@superboyiii
Copy link
Member

I'll test this.

@superboyiii superboyiii mentioned this pull request Mar 31, 2021
6 tasks
Copy link
Member

@superboyiii superboyiii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested. It's OK for me.

@shargon shargon merged commit a0a6f1e into neo-project:master Apr 2, 2021
@shargon shargon deleted the update-calculate-fee branch April 2, 2021 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
6 participants