Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow access TestingEngine to internal #3134

Merged
merged 2 commits into from
Feb 11, 2024
Merged

Allow access TestingEngine to internal #3134

merged 2 commits into from
Feb 11, 2024

Conversation

shargon
Copy link
Member

@shargon shargon commented Feb 11, 2024

I need this change if I want to import from json using SnapshotCache in neo-project/neo-devpack-dotnet#890

@shargon shargon requested a review from Jim8y February 11, 2024 11:11
@shargon shargon added the blocker Issues that are blocking other issues. Check issues details to see what it is blocking. label Feb 11, 2024
@shargon shargon changed the title Change to public StorageKey constructor Allow access TestingEngine to internal Feb 11, 2024
@shargon shargon marked this pull request as draft February 11, 2024 11:50
@shargon shargon marked this pull request as ready for review February 11, 2024 11:50
@shargon shargon merged commit 4a5a7f5 into master Feb 11, 2024
2 checks passed
@shargon shargon deleted the core-sk-public branch February 11, 2024 11:51
@Jim8y
Copy link
Contributor

Jim8y commented Feb 11, 2024

run git pull origin master under the neo folder of the devpack project, you can get the new neo

shargon added a commit that referenced this pull request Feb 14, 2024
* Allow access TestingEngine to internal (#3134)

* Change to public StorageKey constructor

* cschuchardt88's feedback

* Added `publish` to `github packages` (#3072)

* Added nuget packages source

* test

* Changed to windows

* fixed version

* fix

* fix nuget

* fixed nuget.config

* Fixed test

* Nuget fixes

* git

* working release

* Added cron job

* switch to keep 3 packages versions

* Update .github/workflows/main.yml

* Update .github/workflows/main.yml

Co-authored-by: Shargon <shargon@gmail.com>

* change secret

* change delete also

---------

Co-authored-by: Jimmy <jinghui@wayne.edu>
Co-authored-by: Shargon <shargon@gmail.com>

* Optimize opcode price charging (#3131)

* Optimize price

* Jimmy's review

* CS0618

* Update tests/Neo.UnitTests/SmartContract/UT_OpCodePrices.cs

* Avoid Obsolete

---------

Co-authored-by: Jimmy <jinghui@wayne.edu>

---------

Co-authored-by: Christopher Schuchardt <cschuchardt88@gmail.com>
Co-authored-by: Jimmy <jinghui@wayne.edu>
@roman-khimov roman-khimov added this to the v3.7.0 milestone Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocker Issues that are blocking other issues. Check issues details to see what it is blocking.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants