Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Neo Rpc Methods] fix contract rpc methods parameters #3485
base: master
Are you sure you want to change the base?
[Neo Rpc Methods] fix contract rpc methods parameters #3485
Changes from all commits
380c1ac
292c3cc
9fabbf5
656bee9
387561e
a8578c7
12fb1b6
c00d1e7
55331a1
86be323
c0930c1
bd615eb
a8fe721
2f50215
d49a44a
fc1235c
71cc3cd
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SignerWithWitness
?May be
WitnessSigner
is better?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The suggestion is not correct because both account and witness are allowed at the same time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"invocation"
and"verification"
defined as constant values is better?Check warning on line 64 in src/Plugins/RpcServer/Model/SignerWithWitness.cs
GitHub Actions / Test-Everything
Check warning on line 64 in src/Plugins/RpcServer/Model/SignerWithWitness.cs
GitHub Actions / Test (ubuntu-latest)
Check warning on line 64 in src/Plugins/RpcServer/Model/SignerWithWitness.cs
GitHub Actions / Test (ubuntu-latest)
Check warning on line 64 in src/Plugins/RpcServer/Model/SignerWithWitness.cs
GitHub Actions / Test (windows-latest)
Check warning on line 64 in src/Plugins/RpcServer/Model/SignerWithWitness.cs
GitHub Actions / Test (macos-latest)
Check warning on line 65 in src/Plugins/RpcServer/Model/SignerWithWitness.cs
GitHub Actions / Test-Everything
Check warning on line 65 in src/Plugins/RpcServer/Model/SignerWithWitness.cs
GitHub Actions / Test (ubuntu-latest)
Check warning on line 65 in src/Plugins/RpcServer/Model/SignerWithWitness.cs
GitHub Actions / Test (windows-latest)
Check warning on line 65 in src/Plugins/RpcServer/Model/SignerWithWitness.cs
GitHub Actions / Test (macos-latest)
Check warning on line 66 in src/Plugins/RpcServer/Model/SignerWithWitness.cs
GitHub Actions / Test-Everything
Check warning on line 66 in src/Plugins/RpcServer/Model/SignerWithWitness.cs
GitHub Actions / Test-Everything
Check warning on line 66 in src/Plugins/RpcServer/Model/SignerWithWitness.cs
GitHub Actions / Test (ubuntu-latest)
Check warning on line 66 in src/Plugins/RpcServer/Model/SignerWithWitness.cs
GitHub Actions / Test (ubuntu-latest)
Check warning on line 66 in src/Plugins/RpcServer/Model/SignerWithWitness.cs
GitHub Actions / Test (windows-latest)
Check warning on line 66 in src/Plugins/RpcServer/Model/SignerWithWitness.cs
GitHub Actions / Test (windows-latest)
Check warning on line 66 in src/Plugins/RpcServer/Model/SignerWithWitness.cs
GitHub Actions / Test (macos-latest)
Check warning on line 66 in src/Plugins/RpcServer/Model/SignerWithWitness.cs
GitHub Actions / Test (macos-latest)
Check warning on line 67 in src/Plugins/RpcServer/Model/SignerWithWitness.cs
GitHub Actions / Test-Everything
Check warning on line 67 in src/Plugins/RpcServer/Model/SignerWithWitness.cs
GitHub Actions / Test-Everything
Check warning on line 67 in src/Plugins/RpcServer/Model/SignerWithWitness.cs
GitHub Actions / Test (ubuntu-latest)
Check warning on line 67 in src/Plugins/RpcServer/Model/SignerWithWitness.cs
GitHub Actions / Test (ubuntu-latest)
Check warning on line 67 in src/Plugins/RpcServer/Model/SignerWithWitness.cs
GitHub Actions / Test (windows-latest)
Check warning on line 67 in src/Plugins/RpcServer/Model/SignerWithWitness.cs
GitHub Actions / Test (windows-latest)
Check warning on line 67 in src/Plugins/RpcServer/Model/SignerWithWitness.cs
GitHub Actions / Test (macos-latest)
Check warning on line 67 in src/Plugins/RpcServer/Model/SignerWithWitness.cs
GitHub Actions / Test (macos-latest)
Check warning on line 68 in src/Plugins/RpcServer/Model/SignerWithWitness.cs
GitHub Actions / Test-Everything
Check warning on line 68 in src/Plugins/RpcServer/Model/SignerWithWitness.cs
GitHub Actions / Test-Everything
Check warning on line 68 in src/Plugins/RpcServer/Model/SignerWithWitness.cs
GitHub Actions / Test (ubuntu-latest)
Check warning on line 68 in src/Plugins/RpcServer/Model/SignerWithWitness.cs
GitHub Actions / Test (ubuntu-latest)
Check warning on line 68 in src/Plugins/RpcServer/Model/SignerWithWitness.cs
GitHub Actions / Test (windows-latest)
Check warning on line 68 in src/Plugins/RpcServer/Model/SignerWithWitness.cs
GitHub Actions / Test (windows-latest)
Check warning on line 68 in src/Plugins/RpcServer/Model/SignerWithWitness.cs
GitHub Actions / Test (macos-latest)
Check warning on line 68 in src/Plugins/RpcServer/Model/SignerWithWitness.cs
GitHub Actions / Test (macos-latest)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We also need a check against the maximum number of parsed contracts, rules and groups, it's 16.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You may serialize and deserialize parsed items to ensure validity, exactly how the old code does it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still not resolved, we need validation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is already copied from the original code, if its still not working, i would say it has never worked, and should not be a concern of this pr.
Check warning on line 91 in src/Plugins/RpcServer/Model/SignerWithWitness.cs
GitHub Actions / Test (ubuntu-latest)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would adding an
else
statement here make it clearer?