-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: sensitive data compare should use constant time compare to avoid timing attack #3508
Merged
shargon
merged 6 commits into
neo-project:master
from
nan01ab:fix.pass-contant-time-equals
Oct 8, 2024
Merged
fix: sensitive data compare should use constant time compare to avoid timing attack #3508
shargon
merged 6 commits into
neo-project:master
from
nan01ab:fix.pass-contant-time-equals
Oct 8, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vncoelho
reviewed
Oct 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I understand this timing attack. It looks correct and the XOR is quite efficient.
Although it does not look much critical to me in this specific case.
vncoelho
previously approved these changes
Oct 4, 2024
Jim8y
previously approved these changes
Oct 4, 2024
side-channel attack is sort of hot in the research area~~~~ but not sure how industry see it. |
shargon
reviewed
Oct 4, 2024
roman-khimov
requested changes
Oct 4, 2024
shargon
reviewed
Oct 8, 2024
shargon
reviewed
Oct 8, 2024
shargon
approved these changes
Oct 8, 2024
shargon
added a commit
that referenced
this pull request
Oct 8, 2024
15 tasks
roman-khimov
approved these changes
Oct 8, 2024
AnnaShaleva
approved these changes
Oct 8, 2024
Jim8y
approved these changes
Oct 8, 2024
NGDAdmin
pushed a commit
that referenced
this pull request
Oct 9, 2024
Co-authored-by: Jimmy <jinghui@wayne.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
RpcServer.CheckAuth
use direct compare to determine twostring
s equal or not, but sensitive data compare should use constant time compare to avoid timing attackType of change
Checklist: