Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VM Benchmark] benchmark convert #3509

Merged
merged 1 commit into from
Oct 7, 2024

Conversation

Jim8y
Copy link
Contributor

@Jim8y Jim8y commented Oct 5, 2024

Description

StackItem convert has alwasys being one of the most expensive operation in the vm, thus having this pr to benchmark the convert function.

This is part of the plan to fully study the neo-vm performanace and prepare to optimize the performance bottleneck.

More benchmark targeting various other neo vm methods will come later.

Fixes # None

Type of change

  • Optimization (the change is only an optimization)
  • Style (the change is only a code style for better maintenance or standard purpose)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Test Configuration:

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@Jim8y Jim8y added waiting for review NGD Review This pr is an UT/Benchmark PR, NGD can review. unit tests labels Oct 5, 2024
@shargon shargon merged commit bb32a79 into neo-project:master Oct 7, 2024
7 checks passed
@Jim8y Jim8y deleted the benchmark-type-convert branch October 7, 2024 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NGD Review This pr is an UT/Benchmark PR, NGD can review. ready to merge unit tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants