Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.20.2+] The Registry Overhaul #37

Closed
Shadows-of-Fire opened this issue Jul 20, 2023 · 1 comment · Fixed by #257
Closed

[1.20.2+] The Registry Overhaul #37

Shadows-of-Fire opened this issue Jul 20, 2023 · 1 comment · Fixed by #257
Assignees
Labels
1.20 Targeted at Minecraft 1.20 enhancement New (or improvement to existing) feature or request

Comments

@Shadows-of-Fire
Copy link
Contributor

Shadows-of-Fire commented Jul 20, 2023

The Registry Overhaul is the transition from the Forge Registry system to the vanilla Registry system. This issue serves as the general record of all changes under this umbrella, as well as their scope and future steps that have yet to be executed. It is also a work-in-progress. Discussion is also ongoing in the Registries Overhaul thread.

Importantly, this will be a gradual change. This system is huge and has a lot of pieces to it, and we hope to make the transition as seamless as possible.

Phase 1

The first step in this process is to phase out usages of the Forge Registry system. The goals of this phase are to reduce mod usage of the forge registry system and identify feature gaps between the two systems.

Identified Feature Gaps

  • Registry Sync
  • ID Map Serialization to Disk
  • Aliasing
  • Registry Replacement
    • This feature is being removed.

PR's under this umbrella include the following:

  1. [1.20.x] Deprecate RegistryObject for removal #35

Phase 2

The second step is to add feature parity to the vanilla Registry system, based on feature gaps identified in phase 1.

PR's under this umbrella include the following:

Phase 3

The final step is to remove the Forge Registry system in totality, after the vanilla Registry system has achieved parity.

PR's under this umbrella include the following:

@Shadows-of-Fire Shadows-of-Fire added the enhancement New (or improvement to existing) feature or request label Jul 20, 2023
ApexModder added a commit to ApexStudios-Dev/ApexCore-Archive that referenced this issue Jul 30, 2023
…ge changes, and revolve more around vanilla Holder types.

Mentioned NeoForge Registry changes:
neoforged/NeoForge#35
neoforged/NeoForge#37
@Matyrobbrt Matyrobbrt self-assigned this Nov 15, 2023
@Technici4n
Copy link
Member

The changes are coming along nicely in #257.

For an overview of the changes, refer to the WIP blog post: neoforged/websites#14.

@sciwhiz12 sciwhiz12 added the 1.20 Targeted at Minecraft 1.20 label Nov 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.20 Targeted at Minecraft 1.20 enhancement New (or improvement to existing) feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants
@Shadows-of-Fire @Technici4n @sciwhiz12 @SizableShrimp @Matyrobbrt and others