Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NeoOnnx 7d input #674

Merged
merged 2 commits into from
Jul 5, 2022
Merged

Fix NeoOnnx 7d input #674

merged 2 commits into from
Jul 5, 2022

Conversation

zimka
Copy link
Contributor

@zimka zimka commented Jul 5, 2022

Off-by-one error.
BD_Count is equal to 7, so currently NeoOnnx checks that input tensor shape has strictly less than 7 dims.
However NeoML support 7d blobs, so this check should be adjusted.

BlobDesc.h
...
enum TBlobDim {
	BD_BatchLength = 0, // the sequence length
	BD_BatchWidth, // 1
	BD_ListSize, // 2
	BD_Height, //3
	BD_Width, //4
	BD_Depth, //5
	BD_Channels, //6

	BD_Count //7
};

zimka and others added 2 commits July 5, 2022 16:32
Signed-off-by: Boris Zimka <boris.zimka@abbyy.com>
@FedyuninV FedyuninV merged commit 3e1d078 into neoml-lib:master Jul 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants