-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wrap input names in PyLayer #683
Conversation
Signed-off-by: Boris Zimka <boris.zimka@abbyy.com>
The idea is really good, but I think it's better to provide list of tuples |
Signed-off-by: Boris Zimka <boris.zimka@abbyy.com>
I agree that
I have added one more method |
Here is the idea:
The things I don't like in current implementation are Why we have input_names as property, but we have to call method with possibility of wrong idx being passed for getting info about output index? Why these methods are so different? |
Signed-off-by: Boris Zimka <boris.zimka@abbyy.com>
Yep, these questions sound reasonable. I think |
Currently DNN graph structure is inaccessible from NeoML/Python - you can get the list of layers, but you can not read how these layers are connected with each other.
With input names getter it is possible to traverse the whole graph starting from sinks and retrieve it's structure.
It could be used in theory to plot the model, similar to torchviz or maybe even in a plugin for netron.
Also fixes incorrect
assertTrue
which are supposed to beassertEqual