Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NeoML] GradientBoost -- use custom threads #881

Merged
merged 6 commits into from
Jul 12, 2023
Merged

[NeoML] GradientBoost -- use custom threads #881

merged 6 commits into from
Jul 12, 2023

Conversation

favorart
Copy link
Contributor

No description provided.

@favorart favorart marked this pull request as ready for review June 28, 2023 15:05
FedyuninV
FedyuninV requested changes Jul 11, 2023
View reviewed changes
Copy link
Contributor

@FedyuninV FedyuninV left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You've missed a bunch of places:

@favorart favorart marked this pull request as draft July 11, 2023 12:12
@favorart favorart force-pushed the golikovGradBoost branch 2 times, most recently from d54f03d to 742edfe Compare July 12, 2023 09:53
@favorart
Copy link
Contributor Author

You've missed a bunch of places:
...

fixed

@favorart favorart force-pushed the golikovGradBoost branch 2 times, most recently from 1b936c5 to 5923f72 Compare July 12, 2023 15:20
@favorart
[NeoML] GradientBoost -- formatting
4819d08 
Signed-off-by: Kirill Golikov <kirill.golikov@abbyy.com>
@favorart
[NeoML] GradientBoost -- use custom threads
e5bca43 
Signed-off-by: Kirill Golikov <kirill.golikov@abbyy.com>
@favorart
[NeoML] GradientBoost -- excess struct CThreadTask
8d872bd 
clean-up interfaces

Signed-off-by: Kirill Golikov <kirill.golikov@abbyy.com>
@favorart
[NeoML] GradientBoost -- remove for iOS non-available OpenMP
2e5cae3 
Signed-off-by: Kirill Golikov <kirill.golikov@abbyy.com>
@favorart
[NeoML] GradientBoost -- clean-up interface, commenting
cee88aa 
Signed-off-by: Kirill Golikov <kirill.golikov@abbyy.com>
@favorart
[NeoML] GradientBoost -- add to TreeBuilder, FullProblem, FastHistPro…
6365e26 
…blem

Signed-off-by: Kirill Golikov <kirill.golikov@abbyy.com>
@favorart favorart marked this pull request as ready for review July 12, 2023 16:08
@FedyuninV FedyuninV merged commit c19d122 into neoml-lib:master Jul 12, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FedyuninV FedyuninV FedyuninV approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@favorart @FedyuninV