Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Readme Cleanup #229

Merged
merged 5 commits into from
Jan 23, 2020
Merged

Readme Cleanup #229

merged 5 commits into from
Jan 23, 2020

Conversation

cimnine
Copy link
Collaborator

@cimnine cimnine commented Jan 23, 2020

Related Issue: n/a

New Behavior

  • The README has been updated to reflect the change in the build system and to update other outdated information.
  • The Github Action workflows carry specific names. This is to support the next item:
  • The shield for the build status is rendered based on the status of the Github Action Workflow called release.

Contrast to Current Behavior

The shield is based on the build status of Docker Hub's build system. We used that system before, but don't use it anymore. The README also contained outdated information.

Discussion: Benefits and Drawbacks

The benefit is that we provide accurate information.

Changes to the Wiki

n/a

Proposed Release Note Entry

n/a

Double Check

  • I have read the comments and followed the PR template.
  • I have provided and explained my PR according to the information in the comments.
  • My PR targets the develop branch.

@cimnine cimnine added the maintenance The issue describes a maintenance task, such as upgrading a dependency to a certain version. label Jan 23, 2020
@cimnine cimnine changed the title Fix shields Readme Cleanup Jan 23, 2020
@cimnine cimnine marked this pull request as ready for review January 23, 2020 09:42
@cimnine cimnine requested a review from tobiasge January 23, 2020 09:42
@cimnine cimnine merged commit 1f25fba into develop Jan 23, 2020
@cimnine cimnine deleted the fix_shields branch January 23, 2020 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance The issue describes a maintenance task, such as upgrading a dependency to a certain version.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants