Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue:
New Behavior
The
push
workflow is also executed for PRs.Contrast to Current Behavior
We PRs don't get automatic feedback on PRs, because the workflow is not triggered.
Discussion: Benefits and Drawbacks
Currently the workflow
push
was only called when someone pushed to this repository. But since only maintainers can push to this repository, PRs from outsiders were not triggering the pipeline.This PR changes this, so that the pipeline is also triggered for PRs.
When implementing this change I feared that this may cause a problem, namely that this could be used to leak secrets we have configured for pushing to Docker Hub.
After consulting the documentation (and a chat with Github support because I was not certain I understood it the right way) I was assured that secrets should not leak due to someone meddling with the workflow files.
The documentation reads:
Changes to the Wiki
n/a
Proposed Release Note Entry
n/a
Double Check
develop
branch.