Release 0.23.0 #265
Merged
Release 0.23.0 #265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit starts to remove some code redundancy from the startup scripts for easier maintenance.
Add function to load YAML files
This move the setting of user and group permissions in the startup script to its own function.
Permission handling in external function
In the configuration.py we use database 1 as the default but in the .env file we used 0. This sets both values to 1 as the default.
Our docker-compose.yml pointed the env file for the Redis cache to the wrong file. Now the Redis cache password between the netbox.env and redis-cache.env match.
When running tests with ´test.sh´ some errors where logged because now redis-cache instance was running.
…encies Fix configuration inconsistencies
Fix embedded documents for Netbox version v2.7.10 and higher.
- adjust the _Quick Start_ section to match the instructions in the _Getting Started_ guide on our wiki - Adds a new _Getting Help_ section - Improvements in explaining the tags of the published Docker image
Readme improvements
Co-Authored-By: Christian Mäder <cimnine@users.noreply.github.com>
Add RELEASE_CHECK_URL to configuration and default env.
tobiasge
approved these changes
Mar 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: n/a
New Behavior
Contrast to Current Behavior
The current release contains one bug: The Redis configuration is not consistent. Also Netbox evolved and introduced new features, for which we have to account for. Namely the embedded documentation and the release check.
Discussion: Benefits and Drawbacks
All potentially backward-incompatible changes only affect the image, not the surrounding files. I therefore don't expect problems with backwards compatibility. En contraire: The Redis bug was a bug in the surrounding configuration files and should be fixed for earlier Netbox images as well.
Changes to the Wiki
n/a
Proposed Release Note Entry
Double Check
developmasterbranch.