Make the default configuration cluster ready #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cimnine
changed the title
cimnine
force-pushed
the
enhanced_configuration
branch
13 times, most recently
from
1ad7849
to
93908fa
Compare
cimnine
changed the title
twhiston
suggested changes
Dec 14, 2017
README.md
Outdated
| * `DB_*`: Use a persistent database. | ||
| * `EMAIL_*`: Use your own mailserver. | ||
| * `MAX_PAGE_SIZE`: Use the recommended default of 1000. | ||
| * `SUBERUSER_*`: Only define those variables during the initial setup, and drop them once the DB is set up. |
There was a problem hiding this comment.
is SUBERUSER deliberate? or should it be superuser?
There was a problem hiding this comment.
It's deliberate, as those are environment variables and therefore capital by convention.
There was a problem hiding this comment.
not capitalization, spelling, suBeruser
| But if you rather continue to configure your application through environment variables, you may continue to use [the built-in configuration file][docker-config]. | ||
| We discourage storing secrets in environment variables, as environment variable are passed on to all sub-processes and may leak easily into other systems, e.g. error collecting tools that often collect all environment variables whenever an error occurs. | ||
|
|
||
| Therefore we *strongly advise* to make use of the secrets mechanism provided by your container platform (i.e. [Docker Swarm secrets][swarm-secrets], [Kubernetes secrets][k8s-secrets], [OpenShift secrets][openshift-secrets]). |
| @@ -31,3 +34,7 @@ volumes: | |||
| driver: local | |||
| netbox-nginx-config: | |||
| driver: local | |||
| netbox-media-files: | |||
There was a problem hiding this comment.
i cant comment on the line above, as it didnt change, but do we really want to hardcode the nginx port to 80, as that barely ever binds correctly (osx default apache or whatever)
There was a problem hiding this comment.
That's only the 'container internal port'. docker-compose will bind that port to a randomish port.
cimnine
force-pushed
the
enhanced_configuration
branch
2 times, most recently
from
01f3c8c
to
8c6a2be
Compare
|
Good thing that there are (some) unit tests 😇 |
This changes the default configuration to be better prepared for usage with container management platforms, such as Docker Swarm, Kubernetes or OpenShift. Closes #27.
cimnine
force-pushed
the
enhanced_configuration
branch
from
8c6a2be
to
bd9298e
Compare
twhiston
approved these changes
Dec 14, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the default configuration to be better prepared for
usage with container management platforms, such as Docker Swarm,
Kubernetes or OpenShift.
Inspired by #27.