Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't try to run non-python files #307

Merged
merged 1 commit into from
Jun 2, 2020
Merged

Don't try to run non-python files #307

merged 1 commit into from
Jun 2, 2020

Conversation

cimnine
Copy link
Collaborator

@cimnine cimnine commented Jun 2, 2020

Related Issue: N/A

New Behavior

During the startup scripts phase only files who's names end in .py are now executed.

Contrast to Current Behavior

Currently all files in the startup_scripts will be executed, regardless whether they are Python files or not. This leads to errors during startup if a non-python file happens to be in the respective directory. (e.g. desktop.ini or .DS_Store).

Discussion: Benefits and Drawbacks

I think it is valid to have non-python files in the startup_scripts folder. This may not even be intentional, but something your operating system did for your. Therefore the scripts should only try to run *.py files instead of any file in the startup_scripts directory.

Changes to the Wiki

n/a

Proposed Release Note Entry

Non-Python files are not considered as startup_scripts #307

During startup, only the startup_scripts who's filenames end in *.py will be executed.
Previously, all files would be interpreted as Python files.
This has led to unintentional behaviour.

Double Check

  • I have read the comments and followed the PR template.
  • I have explained my PR according to the information in the comments.
  • My PR targets the develop branch.

@cimnine cimnine added the bug This issue describes a confirmed bug. label Jun 2, 2020
@cimnine cimnine added this to the 0.25.0 milestone Jun 2, 2020
@cimnine cimnine requested a review from tobiasge June 2, 2020 11:45
@cimnine cimnine merged commit 7f93b32 into develop Jun 2, 2020
@cimnine cimnine deleted the FixFileMatching branch June 2, 2020 12:43
@tobiasge tobiasge mentioned this pull request Sep 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue describes a confirmed bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants