-
Notifications
You must be signed in to change notification settings - Fork 352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: allow v2 functions to serve /favicon.ico #6145
Conversation
📊 Benchmark resultsComparing with 2547532
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the change itself is ok, but i'd question if we should have this code at all. we don't have it in prod and i don't see what upside there is for having it locally
Agree. I tried finding the original PR that added this, hoping there would be some context on this, but it goes way back to this commit from 2019: 9ffd514 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
We have this weird edge case, where the functions server was catching all requests to /favicon.ico and prevented them from being served by functions. This PR fixes that, by moving the logic to a place where it only impacts routes that don't have a function assigned.