Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix empty lambda warning #166

Merged
merged 1 commit into from
Aug 1, 2019
Merged

fix empty lambda warning #166

merged 1 commit into from
Aug 1, 2019

Conversation

jaredh159
Copy link
Contributor

This PR does two things:

  1. It fixes the logic for determining whether to log out the "empty lambda" warning -- there was mistakenly an OR where there should have been an AND.
  2. It bypasses the warning if the statusCode is set to 204, because a 204 response means no content and shouldn't have a body (in fact supplying a body for a 204 can cause bugs).

@swyxio
Copy link
Contributor

swyxio commented Aug 1, 2019

@RaeesBhatti to review i dont have access to this repo

@RaeesBhatti
Copy link
Contributor

I dont have access as well. Will request access!

@swyxio
Copy link
Contributor

swyxio commented Aug 1, 2019

cool. i'm unsubscribing, all the best!

RaeesBhatti
RaeesBhatti approved these changes Aug 1, 2019
View reviewed changes
Copy link
Contributor

@RaeesBhatti RaeesBhatti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RaeesBhatti RaeesBhatti merged commit 57e5cb5 into netlify:master Aug 1, 2019
@jaredh159 jaredh159 deleted the fix-empty-warning branch August 1, 2019 13:15
@snyk-bot snyk-bot mentioned this pull request Feb 27, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RaeesBhatti RaeesBhatti RaeesBhatti approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jaredh159 @swyxio @RaeesBhatti