Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOC: Add banner for user survey annoucement #6375

Merged
merged 4 commits into from
Jan 28, 2023
Merged

DOC: Add banner for user survey annoucement #6375

merged 4 commits into from
Jan 28, 2023

Conversation

MridulS
Copy link
Member

@MridulS MridulS commented Jan 17, 2023

No description provided.

rossbar
rossbar approved these changes Jan 18, 2023
View reviewed changes
Copy link
Contributor

@rossbar rossbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm in favor of the doc banner to increase visibility. I tried the link in the doc preview and everything looks/functions properly AFAICT.

Should we also add a blurb to the README? If so, it probably makes sense to squash these all into one PR so we can revert it when it's time to close the survey.

dschult
dschult approved these changes Jan 19, 2023
View reviewed changes
Copy link
Member

@dschult dschult left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that this look good. Also, that it might be good to put it in the readme.
What about the networkx.org landing page? And then maybe an email to the networkx-discuss email list.

It'll be good to see the results.

@MridulS
Copy link
Member Author

MridulS commented Jan 19, 2023

The landing page changes should go to https://github.com/networkx/website, I can create a PR there.

@MridulS
Copy link
Member Author

MridulS commented Jan 19, 2023 •
edited
Loading

networkx/website#16 should match the documentation banner.

@dschult
Copy link
Member

dschult commented Jan 19, 2023

That looks good!

Q: is it obvious enough? The link is similar color to the background and at the end of the sentence.
I don't think it will matter much... But we could make the link more obnoxiously noticeable and lead with it.

NetworkX Survey 2023!! 🎉 Fill out the survey to tell us about your ideas, complaints, praises of NetworkX!

(I'm not sure how to do the coloring.) (And this comment is probably just asking for wasted time -- please ignore if you feel that happening. Rabbit holes are often hard to avoid.

@MridulS
Copy link
Member Author

MridulS commented Jan 28, 2023

The lint job failure is due to PyCQA/isort#2077, I'll go ahead and self merge this one.

@MridulS MridulS merged commit 993c371 into networkx:main Jan 28, 2023
MridulS added a commit to MridulS/networkx that referenced this pull request Feb 4, 2023
@MridulS
DOC: Add banner for user survey annoucement (networkx#6375)
55b9741 
* DOC: Add banner for user survey annoucement

* Add survey link in readme

* update survey text

* update wording on website
danieleades pushed a commit to danieleades/networkx that referenced this pull request Feb 9, 2023
@MridulS @danieleades
DOC: Add banner for user survey annoucement (networkx#6375)
9a229b1 
* DOC: Add banner for user survey annoucement

* Add survey link in readme

* update survey text

* update wording on website
@jarrodmillman jarrodmillman added this to the networkx-3.1 milestone Mar 23, 2023
dschult pushed a commit to BrunoBaldissera/networkx that referenced this pull request Oct 23, 2023
@MridulS @dschult
DOC: Add banner for user survey annoucement (networkx#6375)
9e883b8 
* DOC: Add banner for user survey annoucement

* Add survey link in readme

* update survey text

* update wording on website
cvanelteren pushed a commit to cvanelteren/networkx that referenced this pull request Apr 22, 2024
@MridulS @cvanelteren
DOC: Add banner for user survey annoucement (networkx#6375)
bbd1209 
* DOC: Add banner for user survey annoucement

* Add survey link in readme

* update survey text

* update wording on website
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dschult dschult dschult approved these changes

@rossbar rossbar rossbar approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
networkx-3.1
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@MridulS @dschult @rossbar @jarrodmillman