Legacy pickled models support #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KSGulin
requested review from
bfineran,
rahul-tuli and
dfneuralmagic
and removed request for
a team
rahul-tuli
reviewed
Jan 30, 2023
corey-nm
reviewed
Jan 31, 2023
| # pickled, pruned models. | ||
| import models | ||
| from models import common | ||
| setattr(common, "_Add", _Add) # Definition of the _Add module has moved |
There was a problem hiding this comment.
Was hoping to import it directly in common.py, but quickly found myself in circular import hell. This way is probably more intentional anyway
corey-nm
reviewed
Jan 31, 2023
Comment on lines
+41
to
+44
| if "yolov5" not in sys.modules: | ||
| sys.modules["yolov5"] = "" | ||
| sys.modules["yolov5.models"] = models | ||
| sys.modules["yolov5.models.common"] = common |
There was a problem hiding this comment.
So this does work after all? You were saying it wasn't working at first right?
There was a problem hiding this comment.
The issue I was running into with this was actually for the _Add module. During unpickling it was trying to grab _Add from models.common which is not the same as grabbing models.common._Add. Basically trying to append to an existing namespace like that doesn't work. But creating a new namespace was pretty much painless, just gotta make sure to address every module level (yolov5, yolov5.models, etc..)
bfineran
approved these changes
Jan 31, 2023
rahul-tuli
approved these changes
Jan 31, 2023
KSGulin
added a commit
that referenced
this pull request
Jan 31, 2023
KSGulin
added a commit
that referenced
this pull request
Jan 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds backwards compatibility for models that were pickled in a legacy version of our YOLOv5 integration. Three causes of errors are patched here:
load_sparsified_modelwas updated to work with a pickled mode_Addhas been moved, which causes unpickling issues. '_Add' has been programmatically added to common, where it is expectedyolov5.... With the new integration our tools can also be used in the ultralytics upstream repo. Theyolov5andyolov5.modelsnamespaces have been added to accomodate loading these legacy models on upstream as well.Test plan
Local testing with legacy model on both installed package through SparseML and directly on fork