Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT Remove requirements files #240

Merged
merged 9 commits into from
Mar 7, 2024
Merged

MAINT Remove requirements files #240

merged 9 commits into from
Mar 7, 2024

Conversation

adam2392
Copy link
Collaborator

@adam2392 adam2392 commented Mar 6, 2024

Changes proposed in this pull request:

  • Removes unnecessary requirements files
  • build and style are still there because pip install .[style] will also install scikit-tree, which we don't need in the GH actions. Same for build.

Before submitting

  • I've read and followed all steps in the Making a pull request
    section of the CONTRIBUTING docs.
  • I've updated or added any relevant docstrings following the syntax described in the
    Writing docstrings section of the CONTRIBUTING docs.
  • If this PR fixes a bug, I've added a test that will fail without my fix.
  • If this PR adds a new feature, I've added tests that sufficiently cover my new functionality.

After submitting

  • All GitHub Actions jobs for my pull request have passed.

Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
@adam2392 adam2392 marked this pull request as ready for review March 7, 2024 15:59
Signed-off-by: Adam Li <adam2392@gmail.com>
Copy link

codecov bot commented Mar 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.05%. Comparing base (8ceada5) to head (31bd2d7).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #240      +/-   ##
==========================================
+ Coverage   89.94%   90.05%   +0.11%     
==========================================
  Files          54       54              
  Lines        5050     5050              
==========================================
+ Hits         4542     4548       +6     
+ Misses        508      502       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adam2392 adam2392 merged commit 833befe into main Mar 7, 2024
29 checks passed
@adam2392 adam2392 deleted the ci branch March 7, 2024 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants