Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Traceloop Integration Documentation #17868

Merged
merged 7 commits into from
Jul 9, 2024

Conversation

spathlavath
Copy link
Contributor

@spathlavath spathlavath commented Jul 2, 2024

Ticket: https://new-relic.atlassian.net/browse/NR-287279
Description: Created Traceloop Integration Documentation

screencapture-localhost-8000-docs-opentelemetry-get-started-traceloop-llm-observability-traceloop-llm-observability-intro-2024-07-04-11_35_17

Give us some context

  • What problems does this PR solve?
  • Add any context that will help us review your changes such as testing notes,
    links to related docs, screenshots, etc.
  • If your issue relates to an existing GitHub issue, please link to it.

@CLAassistant
Copy link

CLAassistant commented Jul 2, 2024

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link

github-actions bot commented Jul 2, 2024

Hi @spathlavath 👋

Thanks for your pull request! Your PR is in a queue, and a writer will take a look soon. We generally publish small edits within one business day, and larger edits within three days.

We will automatically generate a preview of your request, and will comment with a link when the preview is ready (usually 10 to 20 minutes).

Copy link

netlify bot commented Jul 2, 2024

Deploy Preview for docs-website-netlify ready!

Name Link
🔨 Latest commit 163f2de
🔍 Latest deploy log https://app.netlify.com/sites/docs-website-netlify/deploys/668da041a136e60008526f16
😎 Deploy Preview https://deploy-preview-17868--docs-website-netlify.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ally-sassman
Copy link
Contributor

@jack-berg @alanwest It looks like they're wanting to add this doc to the OTEL section, but I'm thinking it might be better in the AI monitoring section: https://docs.newrelic.com/docs/ai-monitoring/intro-to-ai-monitoring/ Any thoughts?

Copy link

@nirga nirga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice to see this in the wild @spathlavath :)
I'm one of the maintainers of OpenLLMetry, left 2 small comments

@jeff-colucci jeff-colucci self-assigned this Jul 3, 2024
@jeff-colucci jeff-colucci added content requests related to docs site content from_internal Identifies issues/PRs from Relics (except writers) labels Jul 3, 2024
jeff-colucci
jeff-colucci previously approved these changes Jul 3, 2024
@jeff-colucci
Copy link
Contributor

@spathlavath I checked the content and made some slight copy changes. I had some questions about the screenshots:

  1. Are they supposed to be at the bottom or integrated to specific steps?
  2. It seems the 2nd and 3rd screenshot on the bottom are identical to each other?
  3. Have we checked to make sure no keys or anything are in the screenshots? I check for everything usually but I don't always know where to look so it's probably always worth it to double check.

Once I get these addressed this is good to publish.

@spathlavath spathlavath requested a review from nirga July 4, 2024 04:15
@spathlavath
Copy link
Contributor Author

  1. Yes @jeff-colucci they're supposed to be at the bottom but re-ordered them as per the content.
  2. yeah looks like they're identical but the attribute section content is different.
  3. I've checked it, no keys are present in the screenshots.

@spathlavath I checked the content and made some slight copy changes. I had some questions about the screenshots:

  1. Are they supposed to be at the bottom or integrated to specific steps?
  2. It seems the 2nd and 3rd screenshot on the bottom are identical to each other?
  3. Have we checked to make sure no keys or anything are in the screenshots? I check for everything usually but I don't always know where to look so it's probably always worth it to double check.

Once I get these addressed this is good to publish.

@spathlavath spathlavath marked this pull request as draft July 4, 2024 07:01
@spathlavath spathlavath marked this pull request as ready for review July 4, 2024 07:01
@bradleycamacho bradleycamacho merged commit 9e29c31 into newrelic:develop Jul 9, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content requests related to docs site content from_internal Identifies issues/PRs from Relics (except writers)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants