Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(Browser): browser doc audit #18935

Merged
merged 8 commits into from
Oct 15, 2024
Merged

chore(Browser): browser doc audit #18935

merged 8 commits into from
Oct 15, 2024

Conversation

jeff-colucci
Copy link
Contributor

Please follow conventional commit standards
in your commit messages and pull request title.

Give us some context

  • What problems does this PR solve?
  • Add any context that will help us review your changes such as testing notes,
    links to related docs, screenshots, etc.
  • If your issue relates to an existing GitHub issue, please link to it.

@jeff-colucci jeff-colucci added content requests related to docs site content from_tw Identifies issues/PRs from Tech Docs writers labels Oct 11, 2024
@jeff-colucci jeff-colucci self-assigned this Oct 11, 2024
@github-actions GitHub Actions
Copy link

Hi @jeff-colucci 👋

Thanks for your pull request! Your PR is in a queue, and a writer will take a look soon. We generally publish small edits within one business day, and larger edits within three days.

We will automatically generate a preview of your request, and will comment with a link when the preview is ready (usually 10 to 20 minutes).

@netlify Netlify
Copy link

netlify bot commented Oct 11, 2024 •
edited
Loading

✅ Deploy Preview for docs-website-netlify ready!

Name Link
🔨 Latest commit 98ea12a
🔍 Latest deploy log https://app.netlify.com/sites/docs-website-netlify/deploys/670eb3b8d6f064000952b8c8
😎 Deploy Preview https://deploy-preview-18935--docs-website-netlify.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions GitHub Actions
Copy link

[!NOTE]

Our Vale automated writing feedback tool has suggestions for this PR. You can view these suggestions in the Files changed tab. If you're not a New Relic docs writer, we'll review any comments and you don't need to take any action (though feel free to make edits if you like!).

@github-actions GitHub Actions
Copy link

[!NOTE]

Our Vale automated writing feedback tool has suggestions for this PR. You can view these suggestions in the Files changed tab. If you're not a New Relic docs writer, we'll review any comments and you don't need to take any action (though feel free to make edits if you like!).

@jeff-colucci jeff-colucci marked this pull request as ready for review October 11, 2024 15:42
paperclypse
paperclypse reviewed Oct 11, 2024
View reviewed changes
...ser/browser-monitoring/troubleshooting/troubleshoot-your-browser-monitoring-installation.mdx
@@ -69,30 +69,12 @@ These troubleshooting steps apply to problems when the browser monitoring agent

```html
<script type="text/javascript">
(window.NREUM||(NREUM={})).loader_config={xpid:"VRUGVVJS";window.NREUM||(NREUM={}),__nr_require=function a(b,c,d){ ...
;window.NREUM||(NREUM={});NREUM.init={ ...
Copy link
Contributor

@paperclypse paperclypse Oct 11, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jeff-colucci Are the JavaScript examples incomplete on purpose?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to be the correct example based on the audit doc I got, the PR has been reviewed by the SMEs and it didn't come up but I will double check just to make sure before publishing

@github-actions GitHub Actions
Copy link

[!NOTE]

Our Vale automated writing feedback tool has suggestions for this PR. You can view these suggestions in the Files changed tab. If you're not a New Relic docs writer, we'll review any comments and you don't need to take any action (though feel free to make edits if you like!).

jeff-colucci and others added 4 commits October 15, 2024 13:25
@jeff-colucci @ally-sassman
Update src/content/docs/browser/browser-monitoring/troubleshooting/tr…
2a9e33d 
…oubleshoot-your-browser-monitoring-installation.mdx

Co-authored-by: ally sassman <42753584+ally-sassman@users.noreply.github.com>
@jeff-colucci @ally-sassman
Update src/content/docs/browser/new-relic-browser/troubleshooting/tro…
5c502a6 
…ubleshooting-session-trace-collection.mdx

Co-authored-by: ally sassman <42753584+ally-sassman@users.noreply.github.com>
@jeff-colucci @ally-sassman
Update src/content/docs/browser/new-relic-browser/troubleshooting/bro…
8f1fc68 
…wser-data-doesnt-match-other-analytics-tools.mdx

Co-authored-by: ally sassman <42753584+ally-sassman@users.noreply.github.com>
@jeff-colucci @ally-sassman
Update src/content/docs/browser/new-relic-browser/troubleshooting/app…
e3e3dd0 
…-server-requests-greatly-outnumber-browser-pageview-transactions.mdx

Co-authored-by: ally sassman <42753584+ally-sassman@users.noreply.github.com>
@github-actions GitHub Actions
Copy link

[!NOTE]

Our Vale automated writing feedback tool has suggestions for this PR. You can view these suggestions in the Files changed tab. If you're not a New Relic docs writer, we'll review any comments and you don't need to take any action (though feel free to make edits if you like!).

@jeff-colucci @ally-sassman
Update src/content/docs/browser/new-relic-browser/troubleshooting/bro…
98ea12a 
…wser-data-doesnt-match-other-analytics-tools.mdx

Co-authored-by: ally sassman <42753584+ally-sassman@users.noreply.github.com>
@github-actions GitHub Actions
Copy link

[!NOTE]

Our Vale automated writing feedback tool has suggestions for this PR. You can view these suggestions in the Files changed tab. If you're not a New Relic docs writer, we'll review any comments and you don't need to take any action (though feel free to make edits if you like!).

3 similar comments
@github-actions GitHub Actions
Copy link

[!NOTE]

Our Vale automated writing feedback tool has suggestions for this PR. You can view these suggestions in the Files changed tab. If you're not a New Relic docs writer, we'll review any comments and you don't need to take any action (though feel free to make edits if you like!).

@github-actions GitHub Actions
Copy link

[!NOTE]

Our Vale automated writing feedback tool has suggestions for this PR. You can view these suggestions in the Files changed tab. If you're not a New Relic docs writer, we'll review any comments and you don't need to take any action (though feel free to make edits if you like!).

@github-actions GitHub Actions
Copy link

[!NOTE]

Our Vale automated writing feedback tool has suggestions for this PR. You can view these suggestions in the Files changed tab. If you're not a New Relic docs writer, we'll review any comments and you don't need to take any action (though feel free to make edits if you like!).

@jeff-colucci jeff-colucci merged commit 4f61cd8 into develop Oct 15, 2024
16 of 17 checks passed
@jeff-colucci jeff-colucci deleted the browser-doc-changes branch October 15, 2024 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paperclypse paperclypse paperclypse left review comments

@ally-sassman ally-sassman ally-sassman approved these changes

Assignees

@jeff-colucci jeff-colucci

Labels
content requests related to docs site content from_tw Identifies issues/PRs from Tech Docs writers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jeff-colucci @paperclypse @ally-sassman